Re: [PATCH 06/13] delete_refs(): convert error message to lower case

2015-06-09 Thread Michael Haggerty
On 06/08/2015 06:51 PM, Stefan Beller wrote:
 On Mon, Jun 8, 2015 at 4:45 AM, Michael Haggerty mhag...@alum.mit.edu wrote:
 This string is going to have to be re-internationalized anyway because
 of the previous commit. So while we're at it, we might as well convert
 it to lower case as per our usual practice.
 
 Although the previous patch and this are addressing two slightly
 different things,
 we may want to squash this into the previous without dropping any of
 the commit message?
 (It might make reviewing easier, I'd assume)

OK, I will squash them together.

Michael

-- 
Michael Haggerty
mhag...@alum.mit.edu

--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH 06/13] delete_refs(): convert error message to lower case

2015-06-08 Thread Stefan Beller
On Mon, Jun 8, 2015 at 4:45 AM, Michael Haggerty mhag...@alum.mit.edu wrote:
 This string is going to have to be re-internationalized anyway because
 of the previous commit. So while we're at it, we might as well convert
 it to lower case as per our usual practice.

Although the previous patch and this are addressing two slightly
different things,
we may want to squash this into the previous without dropping any of
the commit message?
(It might make reviewing easier, I'd assume)


 Signed-off-by: Michael Haggerty mhag...@alum.mit.edu
 ---
  refs.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

 diff --git a/refs.c b/refs.c
 index 2a2a06d..a10aba8 100644
 --- a/refs.c
 +++ b/refs.c
 @@ -2827,7 +2827,7 @@ int delete_refs(struct string_list *refnames)
 const char *refname = refnames-items[i].string;

 if (delete_ref(refname, NULL, 0))
 -   result |= error(_(Could not remove reference %s), 
 refname);
 +   result |= error(_(could not remove reference %s), 
 refname);
 }

 return result;
 --
 2.1.4

--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html