Re: [PATCH 1/3] gc: improve handling of errors reading gc.log

[Jeff King]

On Mon, Jul 16, 2018 at 11:53:21PM -0700, Jonathan Nieder wrote:

> A collection of minor error handling fixes:
> 
> - use an error message in lower case, following the usual style
> - quote filenames in error messages to make them easier to read and to
>   decrease translation load by matching other 'stat' error messages
> - check for and report errors from 'read', too
> - avoid being confused by a gc.log larger than INT_MAX bytes
> 
> Noticed by code inspection.
> 
> Signed-off-by: Jonathan Nieder 

Thanks, this all looks obviously good.

-Peff

Re: [PATCH 1/3] gc: improve handling of errors reading gc.log

[Junio C Hamano]

Jonathan Nieder  writes:

> - avoid being confused by a gc.log larger than INT_MAX bytes

;-)

>
> Noticed by code inspection.
>
> Signed-off-by: Jonathan Nieder 
> ---

Looks good.