Re: [PATCH 2/2] send-email: add series-cc-cmd option
On Tue, Nov 13, 2012 at 1:37 AM, Junio C Hamano wrote:
> Joe Perches writes:
>
>> On Tue, 2012-11-13 at 03:21 +0530, Ramkumar Ramachandra wrote:
>>> Felipe Contreras wrote:
>>> > cc-cmd is only per-file, and many times receipients get lost without
>>> > seing the full patch series.
>>>
>>> s/seing/seeing
>>>
>>> > [...]
>>>
>>> Looks good otherwise.
>>
>> s/receipients/recipients/ too
>>
>> Practically this is ok but I think it's unnecessary.
>>
>> Output from git format-patch is always in a single
>> directory.
>
> Sorry, but I do not see how the usefulness (or necessity) of this
> new option is connected to the fact that you can tell the command to
> write the patches into a single (possibly new) directory. Care to
> explain?
Basically 'git send-email' would do something like this:
git format-patch -10 -o /tmp
for x in /tmp/*; do cc_cmd $x; done
And the cc-cmd would do something like:
cc_cmd() { do_stuff_with $(dirname $1)/*.patch }
--
Felipe Contreras
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 2/2] send-email: add series-cc-cmd option
Joe Perches writes: > On Tue, 2012-11-13 at 03:21 +0530, Ramkumar Ramachandra wrote: >> Felipe Contreras wrote: >> > cc-cmd is only per-file, and many times receipients get lost without >> > seing the full patch series. >> >> s/seing/seeing >> >> > [...] >> >> Looks good otherwise. > > s/receipients/recipients/ too > > Practically this is ok but I think it's unnecessary. > > Output from git format-patch is always in a single > directory. Sorry, but I do not see how the usefulness (or necessity) of this new option is connected to the fact that you can tell the command to write the patches into a single (possibly new) directory. Care to explain? > My work flow is to use a script for --to and --cc > lines that can be set to emit the same addresses for > all files in a patch series or generate different > addresses per patch file. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 2/2] send-email: add series-cc-cmd option
On Tue, 2012-11-13 at 00:37 +0100, Felipe Contreras wrote: > On Tue, Nov 13, 2012 at 12:13 AM, Joe Perches wrote: > > On Tue, 2012-11-13 at 00:03 +0100, Felipe Contreras wrote: [] > >> For --to-cmd and --cc-cmd? So basically you check the dirname of the > >> argument passed? > > > > yes. basename and dirname > > Well, the basename is irrelevant, because you don't care witch > particular patch is being sent, you are going to process all of them > every time. Well, I do different actions on cover letter patches than other patches because for patch sets that touch lots of files, the cc list can be _very_ long and that can run afoul of other issues like maximum recipient counts for various mailing lists. cheers, Joe -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 2/2] send-email: add series-cc-cmd option
On Tue, Nov 13, 2012 at 12:13 AM, Joe Perches wrote: > On Tue, 2012-11-13 at 00:03 +0100, Felipe Contreras wrote: >> On Mon, Nov 12, 2012 at 11:52 PM, Joe Perches wrote: >> > On Tue, 2012-11-13 at 03:21 +0530, Ramkumar Ramachandra wrote: >> >> Felipe Contreras wrote: >> >> > cc-cmd is only per-file, and many times receipients get lost without >> >> > seing the full patch series. >> >> >> >> s/seing/seeing >> >> >> >> > [...] >> >> >> >> Looks good otherwise. >> > >> > s/receipients/recipients/ too >> > >> > Practically this is ok but I think it's unnecessary. >> > >> > Output from git format-patch is always in a single >> > directory. >> >> A temporary directory. >> >> > My work flow is to use a script for --to and --cc >> > lines that can be set to emit the same addresses for >> > all files in a patch series or generate different >> > addresses per patch file. >> >> For --to-cmd and --cc-cmd? So basically you check the dirname of the >> argument passed? > > yes. basename and dirname Well, the basename is irrelevant, because you don't care witch particular patch is being sent, you are going to process all of them every time. >> While that works, it means you have to run the same command multiple >> times, one for each mail. > > Shrug. it's not a generally significant cost. It is when you use 'git blame' and there's a lot of history: % time git cc-cmd -1 1266686 Peter Krefting junio Tran Ngoc Quan Jiang Xin git cc-cmd -1 1266686 0.23s user 0.16s system 1% cpu 19.991 total > The script could also output the addresses to yet another file. Which would be even more hacky. >> If the command is using something expensive such as 'git blame' and >> you have many patches, this is particularly bad. Also, it's not >> elegant :) > > Elegant is a beholder viewpoint. You think a solution that runs the same instructions multiple times unnecessarily is elegant? All right. -- Felipe Contreras -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 2/2] send-email: add series-cc-cmd option
On Tue, 2012-11-13 at 00:03 +0100, Felipe Contreras wrote: > On Mon, Nov 12, 2012 at 11:52 PM, Joe Perches wrote: > > On Tue, 2012-11-13 at 03:21 +0530, Ramkumar Ramachandra wrote: > >> Felipe Contreras wrote: > >> > cc-cmd is only per-file, and many times receipients get lost without > >> > seing the full patch series. > >> > >> s/seing/seeing > >> > >> > [...] > >> > >> Looks good otherwise. > > > > s/receipients/recipients/ too > > > > Practically this is ok but I think it's unnecessary. > > > > Output from git format-patch is always in a single > > directory. > > A temporary directory. > > > My work flow is to use a script for --to and --cc > > lines that can be set to emit the same addresses for > > all files in a patch series or generate different > > addresses per patch file. > > For --to-cmd and --cc-cmd? So basically you check the dirname of the > argument passed? yes. basename and dirname > While that works, it means you have to run the same command multiple > times, one for each mail. Shrug. it's not a generally significant cost. The script could also output the addresses to yet another file. > If the command is using something expensive such as 'git blame' and > you have many patches, this is particularly bad. Also, it's not > elegant :) Elegant is a beholder viewpoint. cheers, Joe -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 2/2] send-email: add series-cc-cmd option
On Mon, Nov 12, 2012 at 11:52 PM, Joe Perches wrote: > On Tue, 2012-11-13 at 03:21 +0530, Ramkumar Ramachandra wrote: >> Felipe Contreras wrote: >> > cc-cmd is only per-file, and many times receipients get lost without >> > seing the full patch series. >> >> s/seing/seeing >> >> > [...] >> >> Looks good otherwise. > > s/receipients/recipients/ too > > Practically this is ok but I think it's unnecessary. > > Output from git format-patch is always in a single > directory. A temporary directory. > My work flow is to use a script for --to and --cc > lines that can be set to emit the same addresses for > all files in a patch series or generate different > addresses per patch file. For --to-cmd and --cc-cmd? So basically you check the dirname of the argument passed? While that works, it means you have to run the same command multiple times, one for each mail. If the command is using something expensive such as 'git blame' and you have many patches, this is particularly bad. Also, it's not elegant :) -- Felipe Contreras -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 2/2] send-email: add series-cc-cmd option
On Tue, 2012-11-13 at 03:21 +0530, Ramkumar Ramachandra wrote: > Felipe Contreras wrote: > > cc-cmd is only per-file, and many times receipients get lost without > > seing the full patch series. > > s/seing/seeing > > > [...] > > Looks good otherwise. s/receipients/recipients/ too Practically this is ok but I think it's unnecessary. Output from git format-patch is always in a single directory. My work flow is to use a script for --to and --cc lines that can be set to emit the same addresses for all files in a patch series or generate different addresses per patch file. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
