Re: [PATCH 2/2] t5510: do not leave changed cwd
Michael J Gruber writes: > Jeff King venit, vidit, dixit 04.03.2016 12:52: >> On Fri, Mar 04, 2016 at 11:53:50AM +0100, Michael J Gruber wrote: >> >>> t5510 carefully keeps the cwd at the test root by using either subshells >>> or explicit cd'ing back to the root. Use a subshell for the last >>> subtest, too. >> >> I doubt this caused the heisenbug you saw, as we should have an absolute >> path for the trash-dir, and we "cd" to its containing directory before >> deleting it. But this is definitely a good thing to be doing anyway, to >> prevent surprises for new tests added to t5510. > > Absolutely ;) I'll take this one; thanks. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 2/2] t5510: do not leave changed cwd
Jeff King venit, vidit, dixit 04.03.2016 12:52: > On Fri, Mar 04, 2016 at 11:53:50AM +0100, Michael J Gruber wrote: > >> t5510 carefully keeps the cwd at the test root by using either subshells >> or explicit cd'ing back to the root. Use a subshell for the last >> subtest, too. > > I doubt this caused the heisenbug you saw, as we should have an absolute > path for the trash-dir, and we "cd" to its containing directory before > deleting it. But this is definitely a good thing to be doing anyway, to > prevent surprises for new tests added to t5510. Absolutely ;) Michael -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 2/2] t5510: do not leave changed cwd
On Fri, Mar 04, 2016 at 11:53:50AM +0100, Michael J Gruber wrote: > t5510 carefully keeps the cwd at the test root by using either subshells > or explicit cd'ing back to the root. Use a subshell for the last > subtest, too. I doubt this caused the heisenbug you saw, as we should have an absolute path for the trash-dir, and we "cd" to its containing directory before deleting it. But this is definitely a good thing to be doing anyway, to prevent surprises for new tests added to t5510. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
