Re: [PATCH 3/5] t/lib-submodule-update.sh: add new test for submodule internal change

[Stefan Beller]

On Tue, Dec 19, 2017 at 2:31 PM, Jonathan Nieder  wrote:
> Hi,
>
> Stefan Beller wrote:
>
>> The test is marked as a failure as the fix comes in a later patch.
>>
>> Signed-off-by: Stefan Beller 
>> ---
>>  t/lib-submodule-update.sh | 11 +++
>>  1 file changed, 11 insertions(+)
>
> I think I'd find this easier to undrestand if it were squashed with the
> patch that fixes it.

ok, let's squash this into the last patch then.

> This is part of test_submodule_foced_switch --- does that mean it
> affects both checkout -f and reset --hard, or only the latter?

All of
  checkout -f
  reset --hard (and not reset --keep ;)
  read-tree -u --reset

Thanks,
Stefan

Re: [PATCH 3/5] t/lib-submodule-update.sh: add new test for submodule internal change

[Jonathan Nieder]

Hi,

Stefan Beller wrote:

> The test is marked as a failure as the fix comes in a later patch.
>
> Signed-off-by: Stefan Beller 
> ---
>  t/lib-submodule-update.sh | 11 +++
>  1 file changed, 11 insertions(+)

I think I'd find this easier to undrestand if it were squashed with the
patch that fixes it.

This is part of test_submodule_foced_switch --- does that mean it
affects both checkout -f and reset --hard, or only the latter?

Thanks,
Jonathan