Re: [PATCH 7/7] t6120: fix typo in test name

[Junio C Hamano]

Junio C Hamano  writes:

> Stefan Beller  writes:
>
>> Signed-off-by: Stefan Beller 
>> ---
>>  t/t6120-describe.sh | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> Good.  I am guessing that you are sending this as the last/optional
> one because this was found _after_ you worked on other parts of the
> series, but I think it is easier to reason about if this were marked
> as a preliminary clean-up and moved to the front of the series.
>
> Thanks.

Having said that, if you already have v2 that keeps it at the end,
that is fine.  

It's just leaving such an "By the way I found this unrelated one and
fixed it while at it" at the end when submitting will give an
impression that the series is not as well proof-read as it could be,
because a good proof-reader would notice something out-of-place like
this fairly quickly and would move it to the front or even in a
separate preliminary clean-up series.

Re: [PATCH 7/7] t6120: fix typo in test name

[Stefan Beller]

On Tue, Oct 31, 2017 at 6:21 PM, Junio C Hamano  wrote:
> Stefan Beller  writes:
>
>> Signed-off-by: Stefan Beller 
>> ---
>>  t/t6120-describe.sh | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> Good.  I am guessing that you are sending this as the last/optional
> one because this was found _after_ you worked on other parts of the
> series, but I think it is easier to reason about if this were marked
> as a preliminary clean-up and moved to the front of the series.
>
> Thanks.

It can be independent even. I did not bother to put it on its own flight,
but I can shift it to the front of this series.

Thanks,
Stefan

Re: [PATCH 7/7] t6120: fix typo in test name

[Junio C Hamano]

Stefan Beller  writes:

> Signed-off-by: Stefan Beller 
> ---
>  t/t6120-describe.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Good.  I am guessing that you are sending this as the last/optional
one because this was found _after_ you worked on other parts of the
series, but I think it is easier to reason about if this were marked
as a preliminary clean-up and moved to the front of the series.

Thanks.

>
> diff --git a/t/t6120-describe.sh b/t/t6120-describe.sh
> index 3be01316e8..fd329f173a 100755
> --- a/t/t6120-describe.sh
> +++ b/t/t6120-describe.sh
> @@ -304,7 +304,7 @@ test_expect_success 'describe chokes on severely broken 
> submodules' '
>   mv .git/modules/sub1/ .git/modules/sub_moved &&
>   test_must_fail git describe --dirty
>  '
> -test_expect_success 'describe ignoring a borken submodule' '
> +test_expect_success 'describe ignoring a broken submodule' '
>   git describe --broken >out &&
>   test_when_finished "mv .git/modules/sub_moved .git/modules/sub1" &&
>   grep broken out