On 8/20/2018 6:01 PM, Stefan Beller wrote:
On Mon, Aug 20, 2018 at 9:52 AM Derrick Stolee wrote:
There are many places in the codebase that want to iterate over
all packfiles known to Git. The purposes are wide-ranging, and
those that can take advantage of the multi-pack-index already
do. So, use get_all_packs() instead of get_packed_git() to be
sure we are iterating over all packfiles.
So get_packed_git shouold not be used any further?
Do we want to annotate it as deprecated, to be deleted
in the future? Or even remove it as part of this series
(that might be an issue with other series in flight).
Perhaps the right thing to do would be to put a big warning over the
definition to say "only use this if you really don't want
get_all_packs()" or something. The reason I didn't remove it from
packfile.h is that it is used in sha1-name.c alongside
get_multi_pack_index() (so making it 'static' would be incorrect).
