Re: [PATCH v1 5/6] Add porcelain V2 documentation to status manpage
Jeff Hostetlerwrites: > +A series of lines are then displayed for the tracked entries. > + > + R > [\t] > + > +Field Meaning > + > +The staged and unstaged values described earlier, with > +unchanged indicated by a "." rather than a space. Ahh, this is where these mysterious xy came from. You just needed two random consecutive letters, and they could have been ab, ij, or jk. I don't like any of them ;-) Also I have trouble with the "staged and unstaged" here, especially the latter, as the word implies the user did "git rm --cached" on the path earlier, which is not the case. You are saying what is in the index and what is in the working tree. Perhaps using iw instead of xy to make them in sync with the way "git diff --mnemonic-prefix" denotes the contents in the index and in the working tree? Together with s/staged/in the index/ and s/unstaged/in the working tree/, the result would become more consistent with the rest of the system, I suspect. > + The file modes for the entry. > +For unmerged entries, these are the stage 1, 2, and 3, > +and the worktree modes. > +For regular entries, these are the head, index, and > +worktree modes; the fourth is zero. > + The SHA1 values for the entry. > +For unmerged entries, these are the stage 1,2, and 3 values. > +For regular entries, these are the head and index values; > +the third entry is zero. To future-proof, we should use "object name" for what you call "SHA1 value" here, I would think. > +R The rename percentage score. s/percentage score/score/. Do you differentiate between renames and copies? > + The current pathname. It is C-Quoted if necessary. > + The original path. This is only present for staged renames. > +It is C-Quoted if necessary. Seeing "if necessary" makes me wonder if we want to define when it is "necessary". -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v1 5/6] Add porcelain V2 documentation to status manpage
On 20 July 2016 at 17:42, Jeff Hostetlerwrote: > On 07/20/2016 11:29 AM, Jakub Narębski wrote: >> W dniu 2016-07-20 o 00:10, Jeff Hostetler pisze: >> >>> +Porcelain Format Version 2 >>> +~~ >>> + >>> + >>> +If `--branch` is given, a header line showing branch tracking >>> information >>> +is printed. This line begins with "### branch: ". Fields are separated >>> +by a single space. >>> + >>> +FieldMeaning >>> + >>> + | (initial)Current commit >>> + | (detached)Current branch >> >> I was wondering if all possible combinations are allowed. It turns out >> that for technical implementation reasons it is not possible to have >> "(initial) (detached)". >> >> Just something I was wondering about, no need for any change... > > Right. I don't think that combination is possible. Not sure how > to document that succinctly. I don't think it is something we need to document, at least not here. -- Jakub Narębski -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v1 5/6] Add porcelain V2 documentation to status manpage
On 07/20/2016 11:29 AM, Jakub Narębski wrote: W dniu 2016-07-20 o 00:10, Jeff Hostetler pisze: +Porcelain Format Version 2 +~~ + + +If `--branch` is given, a header line showing branch tracking information +is printed. This line begins with "### branch: ". Fields are separated +by a single space. + +FieldMeaning + + | (initial)Current commit + | (detached)Current branch I was wondering if all possible combinations are allowed. It turns out that for technical implementation reasons it is not possible to have "(initial) (detached)". Just something I was wondering about, no need for any change... Right. I don't think that combination is possible. Not sure how to document that succinctly. Jeff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v1 5/6] Add porcelain V2 documentation to status manpage
W dniu 2016-07-20 o 00:10, Jeff Hostetler pisze: > +Porcelain Format Version 2 > +~~ > + > + > +If `--branch` is given, a header line showing branch tracking information > +is printed. This line begins with "### branch: ". Fields are separated > +by a single space. > + > +FieldMeaning > + > + | (initial)Current commit > + | (detached)Current branch I was wondering if all possible combinations are allowed. It turns out that for technical implementation reasons it is not possible to have "(initial) (detached)". Just something I was wondering about, no need for any change... -- Jakub Narębski -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html