Re: [PATCH v12 00/20] index-helper/watchman

2016-06-25 Thread David Turner

On 06/25/2016 09:28 AM, Duy Nguyen wrote:

On Thu, May 19, 2016 at 11:45 PM, David Turner  wrote:

Of course, as soon as I pinged on the previous version, I noticed an issue.
...


A bit off-topic, but you may want to cut a release for libwatchman
(even 0.1.0 would do) so it can be properly packaged.



I've mentioned this to Keith.  Unfortunately, he doesn't seem to have 
write access to the repo yet, but hopefully the Twitter folks will soon 
fix this.

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH v12 00/20] index-helper/watchman

2016-06-25 Thread Duy Nguyen
On Sat, Jun 25, 2016 at 3:28 PM, Duy Nguyen  wrote:
> On Thu, May 19, 2016 at 11:45 PM, David Turner  
> wrote:
>> Of course, as soon as I pinged on the previous version, I noticed an issue.
>> ...
>
> A bit off-topic, but you may want to cut a release for libwatchman
> (even 0.1.0 would do) so it can be properly packaged.

And I'm done with v12! I think most of my comments are minor thing
except the "really || cache_errno == EINVAL" change (which I still
don't see how it's related to watchman).
-- 
Duy
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH v12 00/20] index-helper/watchman

2016-06-25 Thread Duy Nguyen
On Thu, May 19, 2016 at 11:45 PM, David Turner  wrote:
> Of course, as soon as I pinged on the previous version, I noticed an issue.
> ...

A bit off-topic, but you may want to cut a release for libwatchman
(even 0.1.0 would do) so it can be properly packaged.
-- 
Duy
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html