Re: [PATCH v2] grep.c: teach 'git grep --only-matching'

2018-07-06 Thread Junio C Hamano
Taylor Blau  writes:

> On Mon, Jun 25, 2018 at 02:59:07PM -0500, Taylor Blau wrote:
>> Teach 'git grep --only-matching', a new option to only print the
>> matching part(s) of a line.
>>
>> [ ... ]
>>
>> diff --git a/Documentation/git-grep.txt b/Documentation/git-grep.txt
>> index 0de3493b80..078b4e3730 100644
>> --- a/Documentation/git-grep.txt
>> +++ b/Documentation/git-grep.txt
>> @@ -17,7 +17,7 @@ SYNOPSIS
>> [-l | --files-with-matches] [-L | --files-without-match]
>> [(-O | --open-files-in-pager) []]
>> [-z | --null]
>> -   [-c | --count] [--all-match] [-q | --quiet]
>> +   [ -o | --only-matching ] [-c | --count] [--all-match] [-q | --quiet]
>> [--max-depth ]
>> [--color[=] | --no-color]
>> [--break] [--heading] [-p | --show-function]
>> @@ -201,6 +201,10 @@ providing this option will cause it to die.
>>  Output \0 instead of the character that normally follows a
>>  file name.
>>
>> +-o::
>> +--only-matching::
>> +Output only the matching part of the lines.
>
> Junio,
>
> My apologies that I sent the previous patch with incorrect indentation on this
> line. Would you mind queueing this one instead?

Surely, and thanks for telling me what difference to look for
between the versions.  Will replace with the one with indent before
"Output only ...".



Re: [PATCH v2] grep.c: teach 'git grep --only-matching'

2018-07-04 Thread Taylor Blau
On Mon, Jun 25, 2018 at 02:59:07PM -0500, Taylor Blau wrote:
> Teach 'git grep --only-matching', a new option to only print the
> matching part(s) of a line.
>
> [ ... ]
>
> diff --git a/Documentation/git-grep.txt b/Documentation/git-grep.txt
> index 0de3493b80..078b4e3730 100644
> --- a/Documentation/git-grep.txt
> +++ b/Documentation/git-grep.txt
> @@ -17,7 +17,7 @@ SYNOPSIS
>  [-l | --files-with-matches] [-L | --files-without-match]
>  [(-O | --open-files-in-pager) []]
>  [-z | --null]
> -[-c | --count] [--all-match] [-q | --quiet]
> +[ -o | --only-matching ] [-c | --count] [--all-match] [-q | --quiet]
>  [--max-depth ]
>  [--color[=] | --no-color]
>  [--break] [--heading] [-p | --show-function]
> @@ -201,6 +201,10 @@ providing this option will cause it to die.
>   Output \0 instead of the character that normally follows a
>   file name.
>
> +-o::
> +--only-matching::
> + Output only the matching part of the lines.

Junio,

My apologies that I sent the previous patch with incorrect indentation on this
line. Would you mind queueing this one instead?


Thanks,
Taylor