Re: [PATCH v2] partial-clone: design doc

[Jeff Hostetler]

On 12/14/2017 1:24 PM, Junio C Hamano wrote:

Jeff Hostetler  writes:


+- On the client these incomplete packfiles are marked as "promisor pacfiles"


s/pacfiles/packfiles/


+  These "promisor packfiles" consist of a ".promisor" file with
+  arbitrary contents (like the ".keep" files), in addition to
+  their ".pack" and ".idx" files.
+
+  In the future, this ability may be extended to loose objects in case
+  a promisor packfile is accidentally unpacked.


Hmph.

Because we cannot assume that such an "accidental" unpacking would
do anything extra to help us tell the loose objects created out of a
promisor pack from other loose objects, you would end up making any
and all loose objects to serve as if they came from a promisor
remote?  I am not sure if that makes much sense.

Do we really need to write this "in the future" down, before we have
thought things through enough to specify the design at a bit more
detailed level?



good point.  i'll move this to the bottom and elaborate on the
problem rather than the solution.

Jeff

Re: [PATCH v2] partial-clone: design doc

[Junio C Hamano]

Jeff Hostetler  writes:

> +  There are various filters available to accomodate different situations.

s/accomodate/accommodate/

I'll squash in this and /pacfile/packfile/ typofix while queuing.

Thanks.

Re: [PATCH v2] partial-clone: design doc

[Junio C Hamano]

Jeff Hostetler  writes:

> +- On the client these incomplete packfiles are marked as "promisor pacfiles"

s/pacfiles/packfiles/

> +  These "promisor packfiles" consist of a ".promisor" file with
> +  arbitrary contents (like the ".keep" files), in addition to
> +  their ".pack" and ".idx" files.
> +
> +  In the future, this ability may be extended to loose objects in case
> +  a promisor packfile is accidentally unpacked.

Hmph.

Because we cannot assume that such an "accidental" unpacking would
do anything extra to help us tell the loose objects created out of a
promisor pack from other loose objects, you would end up making any
and all loose objects to serve as if they came from a promisor
remote?  I am not sure if that makes much sense.

Do we really need to write this "in the future" down, before we have
thought things through enough to specify the design at a bit more
detailed level?