Re: [PATCH v2] sha1_file: use strbuf_add() instead of strbuf_addf()

[Derrick Stolee]

On 12/4/2017 11:56 AM, Jeff King wrote:

When you put your cover letter first, you need to use "scissors" like:
-- >8 --

to separate it from the commit message. Using three-dashes means "git
am" will include your cover letter as the commit message, and omit your
real commit message entirely.


Thanks. I updated our internal best-practices accordingly.

-Stolee

Re: [PATCH v2] sha1_file: use strbuf_add() instead of strbuf_addf()

[Jeff King]

On Mon, Dec 04, 2017 at 09:06:03AM -0500, Derrick Stolee wrote:

> Thanks for the feedback on v1. This version fixes the cruft_cb
> bug and streamlines the strlen(). I would include an inter-diff
> but it was the same size as the patch.

Thanks, this version looks good to me. One procedural nit:

> Thanks,
> -Stolee
> 
> ---

When you put your cover letter first, you need to use "scissors" like:

-- >8 --

to separate it from the commit message. Using three-dashes means "git
am" will include your cover letter as the commit message, and omit your
real commit message entirely.

-Peff