Re: [PATCH v2 0/5] worktree lock/unlock
On Sun, May 22, 2016 at 6:43 AM, Nguyễn Thái Ngọc Duy wrote: > This should address all of Eric's comments (thanks!). An extra change > I made is free_worktrees() at the end of {,un}lock_worktree() to avoid > leaking. This series depends on nd/worktree-cleanup-post-head-protection. Thanks, this addresses all my comments from the previous round (aside from the suggestion to add a 'locked' field to 'struct worktree' and populate it automatically, which you elected to defer for the present). I re-read the entire series and, aside from the typo in the documentation update of patch 4/5, everything looks fine, and the series is: Reviewed-by: Eric Sunshine -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 0/5] worktree lock/unlock
On Mon, May 23, 2016 at 11:51 AM, Eric Sunshine wrote: > On Sun, May 22, 2016 at 6:43 AM, Nguyễn Thái Ngọc Duy > wrote: >> This should address all of Eric's comments (thanks!). An extra change >> I made is free_worktrees() at the end of {,un}lock_worktree() to avoid >> leaking. This series depends on nd/worktree-cleanup-post-head-protection. > > Thanks, this addresses all my comments from the previous round (aside > from the suggestion to add a 'locked' field to 'struct worktree' and > populate it automatically, which you elected to defer for the > present). If there's another re-roll (likely so), I'm tempted to do that too as it's quite clear now that "locked" belongs in struct worktree. -- Duy -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html