Re: [PATCH v2 00/14] Some fixes and bunch of object_id conversions
> Patches 1 and 2 should be sent separately though. I hoped they could be piggy-backed, but since there will be v3 of this patch series... I'll wait for Junio's opinion. > I look forward to seeing you deal with the object reading part … Yeah, even reading of loose objects does not work on my test branch yet. Turns out some functions (*) depend on each other during conversion to oid - so they are either refactored together in one BIG commit or I need to deploy some temporary hacks to make it possible to split work into smaller batches. (*) refactor of sha1_object_info transitively depends on lookup_replace_object and the other way around. verify_object and verify_tag will also cause some problems. -- | ← Ceci n'est pas une pipe Patryk Obara
Re: [PATCH v2 00/14] Some fixes and bunch of object_id conversions
On Mon, Jan 22, 2018 at 12:04:23PM +0100, Patryk Obara wrote: > sha1_file.c | 100 > ++ You have started the invasion to sha1_file.c. Victory is near! (*) 2018 will be the year of something-other-shan-sha1 :) I've read through the series quickly. It looks good. Patches 1 and 2 should be sent separately though. (*) Technically the hashing part is still easy. I look forward to seeing you deal with the object reading part, especially from pack files. It's fun ;-) -- Duy
