Re: [PATCH v2 2/3] environment: add GIT_PREFIX to local_repo_env
On Fri, Mar 8, 2013 at 4:30 AM, Jeff King p...@peff.net wrote: The GIT_PREFIX variable is set based on our location within the working tree. It should therefore be cleared whenever GIT_WORK_TREE is cleared. In practice, this doesn't cause any bugs, because none of the sub-programs we invoke with local_repo_env cleared actually care about GIT_PREFIX. But this is the right thing to do, and future proofs us again that assumption changing. s/again/against/ -- ES -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 2/3] environment: add GIT_PREFIX to local_repo_env
On Fri, Mar 08, 2013 at 04:39:02PM -0500, Eric Sunshine wrote: On Fri, Mar 8, 2013 at 4:30 AM, Jeff King p...@peff.net wrote: The GIT_PREFIX variable is set based on our location within the working tree. It should therefore be cleared whenever GIT_WORK_TREE is cleared. In practice, this doesn't cause any bugs, because none of the sub-programs we invoke with local_repo_env cleared actually care about GIT_PREFIX. But this is the right thing to do, and future proofs us again that assumption changing. s/again/against/ Yep, thanks. -Peff -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 2/3] environment: add GIT_PREFIX to local_repo_env
Jeff King p...@peff.net writes: On Fri, Mar 08, 2013 at 04:39:02PM -0500, Eric Sunshine wrote: On Fri, Mar 8, 2013 at 4:30 AM, Jeff King p...@peff.net wrote: The GIT_PREFIX variable is set based on our location within the working tree. It should therefore be cleared whenever GIT_WORK_TREE is cleared. In practice, this doesn't cause any bugs, because none of the sub-programs we invoke with local_repo_env cleared actually care about GIT_PREFIX. But this is the right thing to do, and future proofs us again that assumption changing. s/again/against/ Yep, thanks. Thanks; squashed-in. -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
