Re: [PATCH v3 15/35] transport: convert get_refs_list to take a list of ref patterns

2018-02-22 Thread Brandon Williams 
On 02/21, Jonathan Tan wrote:
> On Tue,  6 Feb 2018 17:12:52 -0800
> Brandon Williams  wrote:
> 
> > @@ -21,7 +22,8 @@ struct transport_vtable {
> >  * the ref without a huge amount of effort, it should store it
> >  * in the ref's old_sha1 field; otherwise it should be all 0.
> >  **/
> > -   struct ref *(*get_refs_list)(struct transport *transport, int for_push);
> > +   struct ref *(*get_refs_list)(struct transport *transport, int for_push,
> > +const struct argv_array *ref_patterns);
> 
> Also mention in the documentation that this function is allowed to
> return refs that do not match the ref patterns.

I'll add a comment.

-- 
Brandon Williams

Re: [PATCH v3 15/35] transport: convert get_refs_list to take a list of ref patterns

2018-02-21 Thread Jonathan Tan 
On Tue,  6 Feb 2018 17:12:52 -0800
Brandon Williams  wrote:

> @@ -21,7 +22,8 @@ struct transport_vtable {
>* the ref without a huge amount of effort, it should store it
>* in the ref's old_sha1 field; otherwise it should be all 0.
>**/
> - struct ref *(*get_refs_list)(struct transport *transport, int for_push);
> + struct ref *(*get_refs_list)(struct transport *transport, int for_push,
> +  const struct argv_array *ref_patterns);

Also mention in the documentation that this function is allowed to
return refs that do not match the ref patterns.