Re: [PATCH v4 00/20] repository object
Jeff Hostetler writes: > On 6/22/2017 2:43 PM, Brandon Williams wrote: >> As before you can find this series at: >> https://github.com/bmwill/git/tree/repository-object >> >> Changes in v4: >> >> * Patch 11 is slightly different and turns off all path relocation when a >>worktree is provided instead of just for the index file (Thanks for the >> help >>Jonathan Nieder). >> * 'repo_init()' has a tighter API and now requires that the provided gitdir >> is >>a path to the gitdir instead of either a path to the gitdir or path to the >>worktree (which has a .git file or directory) (Thanks Jonathan Tan). >> * Minor comment and commit message chagnes >> >> Note: Like v3 this series is dependent on on 'bw/config-h' and >>'bw/ls-files-sans-the-index' >> >> Brandon Williams (20): > > I read thru the v1 and v4 versions. Very nice. > And thanks for splitting the earlier parts out > into independent patches. > > I didn't have any complaints, but did want to ACK > that I had looked at it. Thanks.
Re: [PATCH v4 00/20] repository object
On 6/22/2017 2:43 PM, Brandon Williams wrote: As before you can find this series at: https://github.com/bmwill/git/tree/repository-object Changes in v4: * Patch 11 is slightly different and turns off all path relocation when a worktree is provided instead of just for the index file (Thanks for the help Jonathan Nieder). * 'repo_init()' has a tighter API and now requires that the provided gitdir is a path to the gitdir instead of either a path to the gitdir or path to the worktree (which has a .git file or directory) (Thanks Jonathan Tan). * Minor comment and commit message chagnes Note: Like v3 this series is dependent on on 'bw/config-h' and 'bw/ls-files-sans-the-index' Brandon Williams (20): I read thru the v1 and v4 versions. Very nice. And thanks for splitting the earlier parts out into independent patches. I didn't have any complaints, but did want to ACK that I had looked at it. Jeff
Re: [PATCH v4 00/20] repository object
On Thu, Jun 22, 2017 at 11:43 AM, Brandon Williams wrote: > As before you can find this series at: > https://github.com/bmwill/git/tree/repository-object > > Changes in v4: > > * Patch 11 is slightly different and turns off all path relocation when a > worktree is provided instead of just for the index file (Thanks for the help > Jonathan Nieder). > * 'repo_init()' has a tighter API and now requires that the provided gitdir is > a path to the gitdir instead of either a path to the gitdir or path to the > worktree (which has a .git file or directory) (Thanks Jonathan Tan). > * Minor comment and commit message chagnes > > Note: Like v3 this series is dependent on on 'bw/config-h' and > 'bw/ls-files-sans-the-index' I read the whole series and I consider it Reviewed-by: Stefan Beller Thanks, Stefan
