Re: [PATCH v7 08/14] commit-graph: implement git commit-graph read

2018-04-08 Thread Jakub Narebski 
Derrick Stolee  writes:

[...]
>  EXAMPLES
>  
> @@ -45,6 +51,12 @@ EXAMPLES
>  $ git commit-graph write
>  
>  
> +* Read basic information from the commit-graph file.
> ++
> +
> +$ git commit-graph read
> +

It would be better to have example output of this command here, perhaps
together with ASCII-art diagram of the code graph.

[...]
> + if (!graph)
> + die("graph file %s does not exist", graph_name);
> + FREE_AND_NULL(graph_name);

Shouldn't the error message be marked up for translation, too?

Regards,
-- 
Jakub Narębski

Re: [PATCH v7 08/14] commit-graph: implement git commit-graph read

2018-04-03 Thread Derrick Stolee 

On 4/2/2018 5:33 PM, Junio C Hamano wrote:

Derrick Stolee  writes:


From: Derrick Stolee 
...
+static int graph_read(int argc, const char **argv)
+{
+   struct commit_graph *graph = 0;

The previous round said NULL above, not 0, and NULL is the better
way to spell it, I would think.


Sorry about that. Hopefully it is easy to squash.

Re: [PATCH v7 08/14] commit-graph: implement git commit-graph read

2018-04-02 Thread Junio C Hamano 
Derrick Stolee  writes:

> From: Derrick Stolee 
> ...
> +static int graph_read(int argc, const char **argv)
> +{
> + struct commit_graph *graph = 0;

The previous round said NULL above, not 0, and NULL is the better
way to spell it, I would think.