Re: [PATCH v7 2/2] Add Travis CI support

2015-11-24 Thread Lars Schneider

> On 24 Nov 2015, at 21:40, Jeff King  wrote:
> 
> On Mon, Nov 23, 2015 at 09:25:08AM +0100, larsxschnei...@gmail.com wrote:
> 
>> From: Lars Schneider 
>> 
>> The tests are currently executed on "Ubuntu 12.04 LTS Server Edition
>> 64 bit" and on "OS X Mavericks" using gcc and clang.
>> 
>> Perforce and Git-LFS are installed and therefore available for the
>> respective tests.
> 
> Thanks, I find this one a little easier to digest.
> 
> I'm iffy on the NO_GETTEXT change from patch 1. I had hoped we could
> just build out of the box everywhere, but I think the "do we have
> libintl" decision is a hard one. Most people _do_ have it and want it,
> but it sounds like the Travis environment does not. So maybe it is a
> place where it is worth doing the tweak inside travis.yml and leaving
> the stock build alone.

OK, I'll try to fix it in the next roll.

Thanks,
Lars
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH v7 2/2] Add Travis CI support

2015-11-24 Thread Jeff King
On Mon, Nov 23, 2015 at 09:25:08AM +0100, larsxschnei...@gmail.com wrote:

> From: Lars Schneider 
> 
> The tests are currently executed on "Ubuntu 12.04 LTS Server Edition
> 64 bit" and on "OS X Mavericks" using gcc and clang.
> 
> Perforce and Git-LFS are installed and therefore available for the
> respective tests.

Thanks, I find this one a little easier to digest.

I'm iffy on the NO_GETTEXT change from patch 1. I had hoped we could
just build out of the box everywhere, but I think the "do we have
libintl" decision is a hard one. Most people _do_ have it and want it,
but it sounds like the Travis environment does not. So maybe it is a
place where it is worth doing the tweak inside travis.yml and leaving
the stock build alone.

-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html