Re: [PATCH v8 07/10] send-email: reduce dependencies impact on parse_address_line

[Matthieu Moy]

Torsten Bögershausen  writes:

> (Thanks for the quick reply.
> Sorry for the noise about
> #!/usr/bin/perl
> of course we call the right perl)

No problem.

> The new patch seems to be integrated in pu (I tested d08caa8e022f08d)
> Test seems to pass,

Good.

> but some noise is on the channel:

Are you talking about the output of "not ok ... # TODO known breakage"
part, like this:

> ok 24 - same output : 'Jane 'Doe' 
> not ok 25 - same output : Jane\ Doe  # TODO known breakage
> #   Failed (TODO) test 'same output : Jane\ Doe '
> #   at /Users/tb/NoBackup/projects/git/git.next/t/t9000/test.pl line 62.
> # Structures begin differing at:
> #  $got->[0] = '"Jane \ Doe" '
> # $expected->[0] = '"Jane\ Doe" '

?

If so, it seems to be the way Perl's Test::More works with TODO blocks.
I am reluctant to try to change it for us.


-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v8 07/10] send-email: reduce dependencies impact on parse_address_line

[Torsten Bögershausen]

(Thanks for the quick reply.
Sorry for the noise about
#!/usr/bin/perl
of course we call the right perl)

The new patch seems to be integrated in pu (I tested d08caa8e022f08d)
Test seems to pass, but some noise is on the channel:


Initialized empty Git repository in
/Users/tb/NoBackup/projects/git/git.next/t/trash directory.t9000-addresses/.git/
# run 0: Perl address parsing function (perl
/Users/tb/NoBackup/projects/git/git.next/t/t9000/test.pl)
ok 1 - use Git;
ok 2 - same output : Jane
ok 3 - same output : j...@example.com
ok 4 - same output : 
ok 5 - same output : Jane 
ok 6 - same output : Jane Doe 
ok 7 - same output : "Jane" 
ok 8 - same output : "Doe, Jane" 
ok 9 - same output : "Jane@:;\>.,()
ok 10 - same output : Jane!\#$%&'*+-/=?^_{|}~Doe' 
ok 11 - same output : ""
ok 12 - same output : "Jane j...@example.com"
ok 13 - same output : Jane Doe 
ok 14 - same output : Jane   Doe <  j...@example.com  >
ok 15 - same output : Jane @ Doe @ Jane @ Doe
ok 16 - same output : "Jane, 'Doe'" 
ok 17 - same output : 'Doe, "Jane' 
ok 18 - same output : "Jane" "Do"e 
ok 19 - same output : "Jane' Doe" 
ok 20 - same output : "Jane Doe " 
ok 21 - same output : "Jane\" Doe" 
ok 22 - same output : Doe, jane 
ok 23 - same output : "Jane Doe 
ok 24 - same output : 'Jane 'Doe' 
not ok 25 - same output : Jane\ Doe  # TODO known breakage
#   Failed (TODO) test 'same output : Jane\ Doe '
#   at /Users/tb/NoBackup/projects/git/git.next/t/t9000/test.pl line 62.
# Structures begin differing at:
#  $got->[0] = '"Jane \ Doe" '
# $expected->[0] = '"Jane\ Doe" '
not ok 26 - same output : "Doe, Ja"ne  # TODO known breakage
#   Failed (TODO) test 'same output : "Doe, Ja"ne '
#   at /Users/tb/NoBackup/projects/git/git.next/t/t9000/test.pl line 62.
# Structures begin differing at:
#  $got->[0] = '"Doe, Ja" ne '
# $expected->[0] = '"Doe, Ja ne" '
not ok 27 - same output : "Doe, Katarina" Jane  # TODO known
breakage
#   Failed (TODO) test 'same output : "Doe, Katarina" Jane '
#   at /Users/tb/NoBackup/projects/git/git.next/t/t9000/test.pl line 62.
# Structures begin differing at:
#  $got->[0] = '"Doe, Katarina" Jane '
# $expected->[0] = '"Doe, Katarina Jane" '
not ok 28 - same output : Jane@:;\.,()<>Doe  # TODO known 
breakage
#   Failed (TODO) test 'same output : Jane@:;\.,()<>Doe '
#   at /Users/tb/NoBackup/projects/git/git.next/t/t9000/test.pl line 62.
# Structures begin differing at:
#  $got->[1] = '\.'
# $expected->[1] = '"\."'
not ok 29 - same output : Jane j...@example.com # TODO known breakage
#   Failed (TODO) test 'same output : Jane j...@example.com'
#   at /Users/tb/NoBackup/projects/git/git.next/t/t9000/test.pl line 62.
# Structures begin differing at:
#  $got->[0] = 'Jane'
# $expected->[0] = 'janej...@example.com'
not ok 30 - same output :  Jane Doe # TODO known breakage
#   Failed (TODO) test 'same output :  Jane Doe'
#   at /Users/tb/NoBackup/projects/git/git.next/t/t9000/test.pl line 62.
# Structures begin differing at:
#  $got->[0] = 'Jane Doe '
# $expected->[0] = 'jdoe@example.comJaneDoe'
not ok 31 - same output : Jane  Doe # TODO known breakage
#   Failed (TODO) test 'same output : Jane  Doe'
#   at /Users/tb/NoBackup/projects/git/git.next/t/t9000/test.pl line 62.
# Structures begin differing at:
#  $got->[0] = 'Jane Doe '
# $expected->[0] = 'Jane '
not ok 32 - same output : "Jane "Kat"a" ri"na" ",Doe"  # TODO
known breakage
#   Failed (TODO) test 'same output : "Jane "Kat"a" ri"na" ",Doe"
'
#   at /Users/tb/NoBackup/projects/git/git.next/t/t9000/test.pl line 62.
# Structures begin differing at:
#  $got->[0] = '"Jane " Kat "a" ri "na" ",Doe" '
# $expected->[0] = '"Jane  Kat a ri na ,Doe" '
not ok 33 - same output : Jane Doe # TODO known breakage
#   Failed (TODO) test 'same output : Jane Doe'
#   at /Users/tb/NoBackup/projects/git/git.next/t/t9000/test.pl line 62.
# Structures begin differing at:
#  $got->[0] = 'Jane'
# $expected->[0] = 'Jane Doe'
not ok 34 - same output : Jane "Doe " # TODO known breakage
#   Failed (TODO) test 'same output : Jane "Doe "'
#   at /Users/tb/NoBackup/projects/git/git.next/t/t9000/test.pl line 62.
# Structures begin differing at:
#  $got->[0] = 'Jane'
# $expected->[0] = '"Jane Doe "'
not ok 35 - same output : \"Jane Doe  # TODO known breakage
#   Failed (TODO) test 'same output : \"Jane Doe '
#   at /Users/tb/NoBackup/projects/git/git.next/t/t9000/test.pl line 62.
# Structures begin differing at:
#  $got->[0] = '\ " Jane Doe '
# $expected->[0] = '"\"Jane Doe" '
not ok 36 - same output : Jane\"\" Doe  # TODO known breakage
#   Failed (TODO) test 'same output : Jane\"\" Doe '
#   at /Users/tb/NoBackup/projects/git/git.next/t/t9000/test.pl line 62.
# Structures begin differing at:
#  $got->[0] = 'Jane \ " \ " Doe '
# $expected->[0] = '"Jane\"\" Doe" '
not ok 37 - same output : 'Jane "Katarina\" \'