Re: [RFC/PATCH] Replace filepattern with pathspec for consistency
Matthieu Moy matthieu@imag.fr writes: pathspec is the most widely used term, and is the one defined in gitglossary.txt. filepattern was used only in the synopsys for git-add and git-commit, and in git-add.txt. Get rid of it. This patch is obtained with by running: perl -pi -e 's/filepattern/pathspec/' `git grep -l filepattern` Signed-off-by: Matthieu Moy matthieu@imag.fr --- I'm a bit unsure about the changes to the .po files, but I guess doing the substitution there too does the right thing. I am not sure if that is the right thing from the workflow point of view, though. The strings that are fed to _() would be updated with your patch, but the replacement will stay to be filepattern translated to the target language. Translators have to actively hunt for the messages to update them. If you left the .po files untouched, they would notice when git.pot is updated the next time and that will ensure that the affected messages get translated, no? Documentation/git-add.txt | 12 ++-- builtin/add.c | 2 +- builtin/commit.c | 4 ++-- po/de.po | 6 +++--- po/git.pot| 6 +++--- po/sv.po | 6 +++--- po/vi.po | 6 +++--- po/zh_CN.po | 6 +++--- 8 files changed, 24 insertions(+), 24 deletions(-) For the above reason, I am inclined to take the first three and drop the rest. Thanks. -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RFC/PATCH] Replace filepattern with pathspec for consistency
Junio C Hamano gits...@pobox.com writes: The strings that are fed to _() would be updated with your patch, but the replacement will stay to be filepattern translated to the target language. Translators have to actively hunt for the messages to update them. If you left the .po files untouched, they would notice when git.pot is updated the next time and that will ensure that the affected messages get translated, no? Right, and I'm not competent to say how filepattern was translated in any of the languages. Let me know if you want a resend without the po/ part. -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RFC/PATCH] Replace filepattern with pathspec for consistency
Matthieu Moy matthieu@grenoble-inp.fr writes: Junio C Hamano gits...@pobox.com writes: The strings that are fed to _() would be updated with your patch, but the replacement will stay to be filepattern translated to the target language. Translators have to actively hunt for the messages to update them. If you left the .po files untouched, they would notice when git.pot is updated the next time and that will ensure that the affected messages get translated, no? Right, and I'm not competent to say how filepattern was translated in any of the languages. Let me know if you want a resend without the po/ part. I'll remove the tail part of the patch myself. Thanks. -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
