Re: [RFC/PATCH 03/11] ref-filter: add option to filter only branches
Karthik Nayak karthik@gmail.com writes:
+static int filter_branch_kind(struct ref_filter *filter, const char *refname)
+{
+ int kind, i;
+
+ static struct {
+ int kind;
+ const char *prefix;
+ } ref_kind[] = {
+ { REF_LOCAL_BRANCH, refs/heads/ },
+ { REF_REMOTE_BRANCH, refs/remotes/ },
+ };
Nit: I would swap the order of fields, to make it a bit clearer that
this is a kind of dictionary key - value (I think it's more common to
write it in this order than value - key).
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RFC/PATCH 03/11] ref-filter: add option to filter only branches
On Tue, Jul 28, 2015 at 7:08 PM, Matthieu Moy
matthieu@grenoble-inp.fr wrote:
Karthik Nayak karthik@gmail.com writes:
+static int filter_branch_kind(struct ref_filter *filter, const char
*refname)
+{
+ int kind, i;
+
+ static struct {
+ int kind;
+ const char *prefix;
+ } ref_kind[] = {
+ { REF_LOCAL_BRANCH, refs/heads/ },
+ { REF_REMOTE_BRANCH, refs/remotes/ },
+ };
Nit: I would swap the order of fields, to make it a bit clearer that
this is a kind of dictionary key - value (I think it's more common to
write it in this order than value - key).
This was borrowed from branch.c, but ok will change it!
Thanks
--
Regards,
Karthik Nayak
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
