Re: [RFC/PATCH 2/2] status: fix tests to handle new verbose git status during rebase
Thanks for reviewing, I take everything into account and release a v2 ASAP. Guillaume -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RFC/PATCH 2/2] status: fix tests to handle new verbose git status during rebase
Matthieu Moy matthieu@grenoble-inp.fr writes: Guillaume Pagès guillaume.pa...@ensimag.grenoble-inp.fr writes: Signed-off-by: Guillaume Pagès guillaume.pa...@ensimag.grenoble-inp.fr --- t/t7512-status-help.sh | 227 ++--- Your history is not bisectable if you sparate tests and code changes in two patches. Yes. And by squashing the two, you do not have to label 2/2 incorrectly as fix tests; it is merely fixing what 1/2 broke ;-) Plus, as a reviewer, I like seeing changes to the tests next to changes to the code, to show me what is the impact of the code change on the output of the program. That too. is a very important consideration, maybe even more so than bisectability. Thanks. -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RFC/PATCH 2/2] status: fix tests to handle new verbose git status during rebase
Guillaume Pagès guillaume.pa...@ensimag.grenoble-inp.fr writes: Signed-off-by: Guillaume Pagès guillaume.pa...@ensimag.grenoble-inp.fr --- t/t7512-status-help.sh | 227 ++--- Your history is not bisectable if you sparate tests and code changes in two patches. Plus, as a reviewer, I like seeing changes to the tests next to changes to the code, to show me what is the impact of the code change on the output of the program. In this case, this patch really shows what your code is doing, and reviewing PATCH 2 means checking that we agree on the specification, which should not be done _after_ checking the code. + (use git rebase --edit-todo to view and edit) All other status hints use double-quotes around commands. I think this one should, too. -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
