Re: [RFC PATCH v5 4/8] Extract functions out of git_rebase__interactive
On Fri, Mar 23, 2018 at 5:25 PM, Wink Saville wrote:
> The extracted functions are:
> [...]
> Signed-off-by: Wink Saville
> ---
> diff --git a/git-rebase--interactive.sh b/git-rebase--interactive.sh
> @@ -740,8 +740,20 @@ get_missing_commit_check_level () {
> +# Initiate an action. If the cannot be any
s/the/there/
> +# further action it may exec a command
s/\s+/ /
> +# or exit and not return.
> +#
> +# TODO: Consider a cleaner return model so it
> +# never exits and always return 0 if process
> +# is complete.
> +#
> +# Parameter 1 is the action to initiate.
> +#
> +# Returns 0 if the action was able to complete
> +# and if 1 if further processing is required.
> +initiate_action () {
Re: [RFC PATCH v5 4/8] Extract functions out of git_rebase__interactive
Wink Saville writes: > The extracted functions are: > - initiate_action > - setup_reflog_action > - init_basic_state > - init_revisions_and_shortrevisions > - complete_action > > Used by git_rebase__interactive > > Signed-off-by: Wink Saville > Helped-by: Junio C Hamano > Helped-by: Johannes Schindelin > --- I checked the correspondence of lines between the verison before and after the patch, and did not spot anything suspicious. The fact that we do not use "local" and stick to POSIX shell helps a bit, as we do not have to worry about "does this $variable in the split-out function refer to the same data as the original?" ;-) Will queue.
