Re: What's cooking in git.git (Mar 2018, #06; Fri, 30)

[Jeff King]

On Sat, Mar 31, 2018 at 08:41:11PM +0200, Ævar Arnfjörð Bjarmason wrote:

> > [...]
> > * jk/drop-ancient-curl (2017-08-09) 5 commits
> >  - http: #error on too-old curl
> >  - curl: remove ifdef'd code never used with curl >=7.19.4
> >  - http: drop support for curl < 7.19.4
> >  - http: drop support for curl < 7.16.0
> >  - http: drop support for curl < 7.11.1
> >
> >  Some code in http.c that has bitrot is being removed.
> >
> >  Expecting a reroll.
> 
> This has been idle for a long time. Peff: What's left to be done for it?

It wasn't clear to me we actually wanted to do this. It got some
complaints, and then somebody showed up to actually fix the compilation
problems with the old versions.

It also isn't that much of a burden to carry the #ifdefs. The main
question is whether we're doing a disservice to users, since those old
setups likely aren't well tested.

Even if we do proceed, I'm not sure if we'd want the top #error patch,
given the reports that distros will sometimes backport features.

-Peff

Re: js/runtime-prefix-windows, was Re: What's cooking in git.git (Mar 2018, #06; Fri, 30)

[Johannes Sixt]

Am 03.04.2018 um 15:12 schrieb Johannes Schindelin:

On Fri, 30 Mar 2018, Junio C Hamano wrote:


* js/runtime-prefix-windows (2018-03-27) 2 commits
  - mingw/msvc: use the new-style RUNTIME_PREFIX helper
  - exec_cmd: provide a new-style RUNTIME_PREFIX helper for Windows
  (this branch uses dj/runtime-prefix.)

  The Windows port was the first that allowed Git to be installed
  anywhere by having its components refer to each other with relative
  pathnames.  The recent dj/runtime-prefix topic extends the idea to
  other platforms, and its approach has been adopted back in the
  Windows port.

  Is this, together with the dj/runtime-prefix topic, ready for
  'next'?


As far as I am concerned: yes!


Works in my environment, too. No objections.

-- Hannes

js/runtime-prefix-windows, was Re: What's cooking in git.git (Mar 2018, #06; Fri, 30)

[Johannes Schindelin]

Hi Junio,

On Fri, 30 Mar 2018, Junio C Hamano wrote:

> * js/runtime-prefix-windows (2018-03-27) 2 commits
>  - mingw/msvc: use the new-style RUNTIME_PREFIX helper
>  - exec_cmd: provide a new-style RUNTIME_PREFIX helper for Windows
>  (this branch uses dj/runtime-prefix.)
> 
>  The Windows port was the first that allowed Git to be installed
>  anywhere by having its components refer to each other with relative
>  pathnames.  The recent dj/runtime-prefix topic extends the idea to
>  other platforms, and its approach has been adopted back in the
>  Windows port.
> 
>  Is this, together with the dj/runtime-prefix topic, ready for
>  'next'?

As far as I am concerned: yes!

Ciao,
Dscho

Re: What's cooking in git.git (Mar 2018, #06; Fri, 30)

[Ævar Arnfjörð Bjarmason]

On Fri, Mar 30 2018, Junio C. Hamano wrote:

> [...]
> * jk/drop-ancient-curl (2017-08-09) 5 commits
>  - http: #error on too-old curl
>  - curl: remove ifdef'd code never used with curl >=7.19.4
>  - http: drop support for curl < 7.19.4
>  - http: drop support for curl < 7.16.0
>  - http: drop support for curl < 7.11.1
>
>  Some code in http.c that has bitrot is being removed.
>
>  Expecting a reroll.

This has been idle for a long time. Peff: What's left to be done for it?

> [...]
> * dj/runtime-prefix (2018-03-25) 3 commits
>  - exec_cmd: RUNTIME_PREFIX on some POSIX systems
>  - Makefile: add Perl runtime prefix support
>  - Makefile: generate Perl header from template file
>  (this branch is used by js/runtime-prefix-windows.)
>
>  A build-time option has been added to allow Git to be told to refer
>  to its associated files relative to the main binary, in the same
>  way that has been possible on Windows for quite some time, for
>  Linux, BSDs and Darwin.
>
>  Is this, together with the js/runtime-prefix-windows topic, ready
>  for 'next'?

dj/runtime-prefix look good to me (and I've been the reviewing it the
most it seems), I don't see any problems with js/runtime-prefix-windows
from peeking at it, but I haven't run it for obvious reasons.

Re: What's cooking in git.git (Mar 2018, #06; Fri, 30)

[Duy Nguyen]

On Fri, Mar 30, 2018 at 10:38 PM, Junio C Hamano  wrote:
> * nd/repack-keep-pack (2018-03-26) 7 commits
>  - pack-objects: show some progress when counting kept objects
>  - gc --auto: exclude base pack if not enough mem to "repack -ad"
>  - gc: handle a corner case in gc.bigPackThreshold
>  - gc: add gc.bigPackThreshold config
>  - gc: add --keep-largest-pack option
>  - repack: add --keep-pack option
>  - t7700: have closing quote of a test at the beginning of line
>
>  "git gc" in a large repository takes a lot of time as it considers
>  to repack all objects into one pack by default.  The command has
>  been taught to pretend as if the largest existing packfile is
>  marked with ".keep" so that it is left untouched while objects in
>  other packs and loose ones are repacked.
>
>  Reroll exists, but it seems to be still slushy.
>  cf. <20180316192745.19557-1-pclo...@gmail.com>

The next one v4 [1] should be less slushy.

[1] https://public-inbox.org/git/20180324072507.21059-1-pclo...@gmail.com/#t
-- 
Duy

Re: What's cooking in git.git (Mar 2018, #06; Fri, 30)

[Jeff Hostetler]

On 3/30/2018 4:38 PM, Junio C Hamano wrote:


* jh/json-writer (2018-03-28) 1 commit
  - json_writer: new routines to create data in JSON format

  Is this ready for 'next'?


Yes, I believe it is.  This has the V6 fixup for the HEREDOC
with leading whitespace, so I think we're good.

Thanks
Jeff

Re: What's cooking in git.git (Mar 2018, #06; Fri, 30)

[Junio C Hamano]

Junio C Hamano  writes:

> --
> [Graduated to "master"]
>
> * jh/partial-clone (2018-03-25) 1 commit
>   (merged to 'next' on 2018-03-28 at 2a0a7aef8e)
>  + unpack-trees: release oid_array after use in check_updates()
>
>  Hotfix.

Not listed in the above, but this round also merges the hotfix
c7620bd0 ("upload-pack: disable object filtering when disabled by
config", 2018-03-28) from Jonathan Nieder that makes sure that
"uploadpack.allowfilter" does disable the feature even when the
client makes an unsolicited request to trigger the "filter" feature.

It is not (yet) clear how I screwed up this report; sorry about
that.

Re: What's cooking in git.git (Mar 2018, #06; Fri, 30)

[Thomas Gummerer]

On 03/30, Junio C Hamano wrote:

> * tg/worktree-add-existing-branch (2018-03-27) 6 commits
>  - t2025: rename now outdated branch name
>  - worktree: teach "add" to check out existing branches
>  - worktree: factor out dwim_branch function
>  - worktree: remove force_new_branch from struct add_opts
>  - worktree: be clearer when "add" dwim-ery kicks in
>  - worktree: improve message when creating a new worktree
> 
>  "git worktree add" learned to check out an existing branch.
> 
>  Is this ready for 'next'?

Not quite yet.  Eric spotted some UI deficiencies which I'm currently
trying to address.  I hope to re-roll this in a few days with those
deficiencies fixed.