Re: Subject: [PATCH 0/9] hdr-check

2018-09-18 Thread Elijah Newren 
Hi Ramsay,

On Tue, Sep 18, 2018 at 5:09 PM Ramsay Jones
 wrote;
> This series follows on from a quick "just before bedtime" exercise
> recently[1]. The new 'hdr-check' target essentially automates what
> Elijah did by hand.

Cool, thanks for doing this.  I believe I only tried to directly check
the toplevel header files (any fixes I made to headers in
subdirectories were just due to their indirect inclusion), so it's not
surprising to see that you needed to fix up some headers in
subdirectories.  It is slightly surprising to me that we've already
gained 6 cases of toplevel header files that needed fixes; that
suggests this hdr-check is even more useful than I would have
suspected.

The Make-fu in patch 1 is beyond the make I know, but the other
patches are all pretty simple and look good to me.

Subject: [PATCH 0/9] hdr-check

2018-09-18 Thread Ramsay Jones 



This series follows on from a quick "just before bedtime" exercise
recently[1]. The new 'hdr-check' target essentially automates what
Elijah did by hand. I tend to run:

  $ make -h hdr-check >hcout 2>&1
  $ vim hcout

... and I only just realised that if somebody wanted to add this to
an travis CI job (it won't be me), then it would be a good idea to
add '-Werror' to the compiler command; otherwise 'make' would not
exit with an error if the compiler only issues warnings.

This series was built on the current 'master' branch (@2d3b1c576c),
although patches #1-6 apply on v2.19.0. (The last three patches used
to be on 'next' until last night!).

If I merge this to 'next', I have to add an additional patch for a
clean 'hdr-check'. Exactly the same comment for the current 'pu'
branch.

[1] 
https://public-inbox.org/git/b8553a50-6b97-2b45-2f7b-cfe257654...@ramsayjones.plus.com/

ATB,
Ramsay Jones

Ramsay Jones (9):
  Makefile: add a hdr-check target
  json-writer.h: add missing include (hdr-check)
  ewah/ewok_rlw.h: add missing include (hdr-check)
  refs/ref-cache.h: add missing declarations (hdr-check)
  refs/packed-backend.h: add missing declaration (hdr-check)
  refs/refs-internal.h: add missing declarations (hdr-check)
  midx.h: add missing forward declarations (hdr-check)
  delta-islands.h: add missing forward declarations (hdr-check)
  commit-reach.h: add missing declarations (hdr-check)

 Makefile  | 12 
 commit-reach.h|  5 +++--
 delta-islands.h   |  4 
 ewah/ewok_rlw.h   |  2 ++
 json-writer.h |  2 ++
 midx.h|  3 +++
 refs/packed-backend.h |  2 ++
 refs/ref-cache.h  |  3 +++
 refs/refs-internal.h  |  4 
 9 files changed, 35 insertions(+), 2 deletions(-)

-- 
2.19.0