Re: git-clone removes destination path after permission deny

2018-08-16 Thread Jonathan Nieder
Hi,

Agis wrote:
> On 16 Aug 2018, at 15:08, Agis  wrote:

>>$ mkdir foo
>>$ git clone g...@github.com:agis/private.git foo
>>Cloning into 'foo'...
>>Permission denied (publickey).
>>fatal: Could not read from remote repository.
[...]
>>$ ls foo
>>ls: cannot access 'foo': No such file or directory
>>
>> Is this expected behavior?
[...]
> Nevermind, this is does not happen in 2.18.0. Apparently it was
> fixed somewhere between 2.11 and 2.18.

Indeed, this was fixed by v2.16.2~5^2 (clone: do not clean up
directories we didn't create, 2018-01-02).

Cc-ing the author of that change (Peff) so he can meet a happy
user of it. :)

Thanks and hope that helps,
Jonathan


Re: git-clone removes destination path after permission deny

2018-08-16 Thread Agis
Nevermind, this is does not happen in 2.18.0. Apparently it was fixed somewhere 
between 2.11 and 2.18.

> On 16 Aug 2018, at 15:08, Agis  wrote:
> 
> Hello.
> 
> I've recently observed the following:
> 
>$ mkdir foo
>$ # try to clone from a repository that you have no access to
>$ git clone g...@github.com:agis/private.git foo
>Cloning into 'foo'...
>Permission denied (publickey).
>fatal: Could not read from remote repository.
> 
>Please make sure you have the correct access rights
>and the repository exists.
>$ ls foo
>ls: cannot access 'foo': No such file or directory
> 
> Is this expected behavior?
> 
> Thanks in advance,
> Agis
> 
> P.S. If this is something that should be fixed, I'd be happy to prepare a 
> patch
> 



git-clone removes destination path after permission deny

2018-08-16 Thread Agis
Hello.

I've recently observed the following:

$ mkdir foo
$ # try to clone from a repository that you have no access to
$ git clone g...@github.com:agis/private.git foo
Cloning into 'foo'...
Permission denied (publickey).
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
$ ls foo
ls: cannot access 'foo': No such file or directory

Is this expected behavior?

Thanks in advance,
Agis

P.S. If this is something that should be fixed, I'd be happy to prepare a patch