Re: [PATCH v2 0/2] Re: gitk: can't reload commits with new key binding
On Tue, Oct 02, 2012 at 11:04:43AM -0400, Andrew Wong wrote: > Refactored the code for binding modified function keys as Junio suggested. > > Andrew Wong (2): > gitk: Refactor code for binding modified function keys > gitk: Use bindshiftfunctionkey to bind Shift-F5 > > gitk | 10 +++--- > 1 file changed, 7 insertions(+), 3 deletions(-) Thanks, applied both patches. Paul. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 0/2] Re: gitk: can't reload commits with new key binding
Can I get some feedback on these two patches? It'd be great to have them merged into gitk. Thanks. On 10/02/2012 11:04 AM, Andrew Wong wrote: Refactored the code for binding modified function keys as Junio suggested. Andrew Wong (2): gitk: Refactor code for binding modified function keys gitk: Use bindshiftfunctionkey to bind Shift-F5 gitk | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 0/2] Re: gitk: can't reload commits with new key binding
Hi, (Sorry for the delayed reply, was out of town.) On Tue, Oct 02, 2012 at 11:04:43AM -0400, Andrew Wong wrote: > Refactored the code for binding modified function keys as Junio suggested. > > Andrew Wong (2): > gitk: Refactor code for binding modified function keys > gitk: Use bindshiftfunctionkey to bind Shift-F5 > Thanks, this series solves the problem for me. Best, Gábor -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 0/2] Re: gitk: can't reload commits with new key binding
Could we look into getting this patch into git/gitk? On 10/02/12 11:04, Andrew Wong wrote: > Refactored the code for binding modified function keys as Junio suggested. > > Andrew Wong (2): > gitk: Refactor code for binding modified function keys > gitk: Use bindshiftfunctionkey to bind Shift-F5 > > gitk | 10 +++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH v2 0/2] Re: gitk: can't reload commits with new key binding
Refactored the code for binding modified function keys as Junio suggested. Andrew Wong (2): gitk: Refactor code for binding modified function keys gitk: Use bindshiftfunctionkey to bind Shift-F5 gitk | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) -- 1.7.12.1.382.gb0576a6 -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: gitk: can't reload commits with new key binding
Sorry, my previous "git send-email" screwed up. Resending the email again. I was running into the same issue too. It turns out that on some machines Shift-F5 is mapped to Shift-XF86_Switch_VT_5. My patch includes a workaround. The same workaround was used for Shift-F4. Andrew Wong (1): gitk: Add workaround for system where Shift-F5 mapped to Shift-XF86_Switch_VT_5 gitk-git/gitk | 1 + 1 file changed, 1 insertion(+) -- 1.7.12.1.382.gb0576a6 -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
gitk: can't reload commits with new key binding
Hi, a135f214 (gitk: Avoid Meta1-F5, 2012-04-07) changed the key binding for reloading commits to shift-F5, but this new key binding doesn't seem to be working here, because it doesn't call reloadcommits(). Choosing the reload menu item works. Shift-F5 works properly in other applications. Any ideas? Thanks, Gábor -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
