Re: [PATCH] Remove contrib/examples/*
On Sun, Mar 25, 2018 at 08:46:53PM +, Ævar Arnfjörð Bjarmason wrote: > There were some side discussions at Git Merge this year about how we > should just update the README to tell users they can dig these up from > the history if the need them, do that. > > Looking at the "git log" for this directory we get quite a bit more > patch churn than we should here, mainly from things fixing various > tree-wide issues. > > There's also confusion on the list occasionally about how these should > be treated, "Re: [PATCH 1/4] stash: convert apply to > builtin" > () > being the latest example of that. I'm in favor of this. I don't think I've ever come across this directory and _not_ been annoyed (because it was the result of a grep and was just cluttering the results). And I think your README change leaves a nice signpost for people who might be digging around for plumbing examples. > The people on CC got this, but it seems the git ML rejected the message > as it's too big. The abbreviated patches is here quoted inline, and at: > https://github.com/avar/git/commit/cc578c81c2cb2999b1a0b73954610bd74951c37b I was going to suggest re-sending with "-D", but it looks like "git apply" will not apply such a patch (even though it could in theory realize that the current blob matches the preimage sha1 and it would be safe to remove it). -Peff
Re: [PATCH v7 0/3] RUNTIME_PREFIX relocatable Git
Dan Jacques writes: > This patch set expands support for the RUNTIME_PREFIX configuration flag, > currently only used on Windows builds, to include Linux, Darwin, and > FreeBSD. When Git is built with RUNTIME_PREFIX enabled, it resolves its > ancillary paths relative to the runtime location of its executable > rather than hard-coding them at compile-time, allowing a Git > installation to be deployed to a path other than the one in which it > was built/installed. > > Note that RUNTIME_PREFIX is not currently used outside of Windows. > This patch set should not have an impact on default Git builds. > > This is a minor update based on comments from the v6 series. If all's > well, I'm hoping this set is good to go. When testing the non-relocatable (i.e. traditional) Git, we use GIT_EXEC_PATH and bin-wrappers/ trick to ensure that we test the version we just have built, not a random version that happen to be on the $PATH, without requiring the built product first to be installed before being tested. From the diffstat for this patchset, I am guessing that you are using the same mechanism even when testing the relocatable one. I wonder if the relocatable Git would allow a simpler arrangement to test without installing. I am asking merely out of curiosity, not suggesting to make a trial install somewhere in the build area and run the built Git normally without GIT_EXEC_PATH trick. Thanks.
