[PATCH] i386 visws: Add machine_shutdown and emergency_restart

2005-08-06 Thread Linux Kernel Mailing List
tree fa988e457ce99f4eb9a85da9daf84951b5fcfe15
parent 094528a7fb3f75a83673e5cc3271fd466f2e278d
author Eric W. Biederman <[EMAIL PROTECTED]> Sun, 07 Aug 2005 01:45:10 -0600
committer Linus Torvalds <[EMAIL PROTECTED]> Sun, 07 Aug 2005 02:54:57 -0700

[PATCH] i386 visws: Add machine_shutdown and emergency_restart

Another x86 subarchitecture bit I missed.  This adds both
machine_emergency_restart missed in my reboot fixes and
machine_shutdown needed for kexec support.

Signed-off-by: Linus Torvalds <[EMAIL PROTECTED]>

 arch/i386/mach-visws/reboot.c |   11 ++-
 1 files changed, 10 insertions(+), 1 deletion(-)

diff --git a/arch/i386/mach-visws/reboot.c b/arch/i386/mach-visws/reboot.c
--- a/arch/i386/mach-visws/reboot.c
+++ b/arch/i386/mach-visws/reboot.c
@@ -9,12 +9,15 @@
 void (*pm_power_off)(void);
 EXPORT_SYMBOL(pm_power_off);
 
-void machine_restart(char * __unused)
+void machine_shutdown(void)
 {
 #ifdef CONFIG_SMP
smp_send_stop();
 #endif
+}
 
+void machine_emergency_restart(void)
+{
/*
 * Visual Workstations restart after this
 * register is poked on the PIIX4
@@ -22,6 +25,12 @@ void machine_restart(char * __unused)
outb(PIIX4_RESET_VAL, PIIX4_RESET_PORT);
 }
 
+void machine_restart(char * __unused)
+{
+   machine_shutdown();
+   machine_emergency_restart();
+}
+
 void machine_power_off(void)
 {
unsigned short pm_status;
-
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH] i386 voyager: Add machine_shutdown

2005-08-06 Thread Linux Kernel Mailing List
tree 4d9fb39a134852f7dfdb2c49055f378a686ef072
parent cd5098d254a28a5980bc6dec9644f99ee884a548
author Eric W. Biederman <[EMAIL PROTECTED]> Sun, 07 Aug 2005 01:42:45 -0600
committer Linus Torvalds <[EMAIL PROTECTED]> Sun, 07 Aug 2005 02:54:57 -0700

[PATCH] i386 voyager: Add machine_shutdown

Here is one more bit of breakage my x86 sub-architecture
confusion caused.

Add machine_shutdown to voyager so it will compile with CONFIG_KEXEC.

Signed-off-by: Linus Torvalds <[EMAIL PROTECTED]>

 arch/i386/mach-voyager/voyager_basic.c |6 ++
 1 files changed, 6 insertions(+)

diff --git a/arch/i386/mach-voyager/voyager_basic.c 
b/arch/i386/mach-voyager/voyager_basic.c
--- a/arch/i386/mach-voyager/voyager_basic.c
+++ b/arch/i386/mach-voyager/voyager_basic.c
@@ -252,6 +252,12 @@ kb_wait(void)
 }
 
 void
+machine_shutdown(void)
+{
+   /* Architecture specific shutdown needed before a kexec */
+}
+
+void
 machine_restart(char *cmd)
 {
printk("Voyager Warm Restart\n");
-
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH] x86_64 bootmem: sparse_mem/kexec merge bug.

2005-08-06 Thread Linux Kernel Mailing List
tree 10d49c7f5dce5c7f1ec4ddd6572490827be874cf
parent 36cf446c2c4be6bae01517ea539dcebaf85c9fdf
author Eric W. Biederman <[EMAIL PROTECTED]> Sun, 07 Aug 2005 01:47:36 -0600
committer Linus Torvalds <[EMAIL PROTECTED]> Sun, 07 Aug 2005 03:06:30 -0700

[PATCH] x86_64 bootmem: sparse_mem/kexec merge bug.

When the sparse mem changes and the kexec changes
were merged into setup.c they came in, in the wrong order.
This patch changes the order so we don't run sparse_init
which uses the bootmem allocator until we all of the
reserve_bootmem calls has been made.

Signed-off-by: Eric W. Biederman <[EMAIL PROTECTED]>
Signed-off-by: Linus Torvalds <[EMAIL PROTECTED]>

 arch/x86_64/kernel/setup.c |6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/x86_64/kernel/setup.c b/arch/x86_64/kernel/setup.c
--- a/arch/x86_64/kernel/setup.c
+++ b/arch/x86_64/kernel/setup.c
@@ -645,15 +645,15 @@ void __init setup_arch(char **cmdline_p)
}
}
 #endif
-
-   sparse_init();
-
 #ifdef CONFIG_KEXEC
if (crashk_res.start != crashk_res.end) {
reserve_bootmem(crashk_res.start,
crashk_res.end - crashk_res.start + 1);
}
 #endif
+
+   sparse_init();
+
paging_init();
 
check_ioapic();
-
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Check input buffer size in zisofs

2005-08-06 Thread Linux Kernel Mailing List
tree eff86901dda863299501c6e729a2d621f607314f
parent 243393c90f2b7cb781fd794e22786e9c8547901a
author Linus Torvalds <[EMAIL PROTECTED]> Sat, 06 Aug 2005 23:42:06 -0700
committer Linus Torvalds <[EMAIL PROTECTED]> Sat, 06 Aug 2005 23:42:06 -0700

Check input buffer size in zisofs

This uses the new deflateBound() thing to sanity-check the input to the
zlib decompressor before we even bother to start reading in the blocks.

Problem noted by Tim Yamin <[EMAIL PROTECTED]>

 fs/isofs/compress.c |6 ++
 1 files changed, 6 insertions(+)

diff --git a/fs/isofs/compress.c b/fs/isofs/compress.c
--- a/fs/isofs/compress.c
+++ b/fs/isofs/compress.c
@@ -129,8 +129,14 @@ static int zisofs_readpage(struct file *
cend = le32_to_cpu(*(__le32 *)(bh->b_data + (blockendptr & bufmask)));
brelse(bh);
 
+   if (cstart > cend)
+   goto eio;
+   
csize = cend-cstart;
 
+   if (csize > deflateBound(1UL << zisofs_block_shift))
+   goto eio;
+
/* Now page[] contains an array of pages, any of which can be NULL,
   and the locks on which we hold.  We should now read the data and
   release the pages.  If the pages are NULL the decompressed data
-
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


ppc: Export __handle_mm_fault for MOL

2005-08-06 Thread Linux Kernel Mailing List
tree cd2d71428286934c89294ad12ebe4928c9425302
parent fab5a60a29f98f17256a4183e34a414f6db67569
author Linus Torvalds <[EMAIL PROTECTED]> Sat, 06 Aug 2005 23:44:37 -0700
committer Linus Torvalds <[EMAIL PROTECTED]> Sat, 06 Aug 2005 23:44:37 -0700

ppc: Export __handle_mm_fault for MOL

When we did the handle_mm_fault cleanup and get_user_page() race fixes,
handle_mm_fault turned into an inline function that called the real
__handle_mm_fault() code.  The export needed for MOL on ppc wasn't
updated to match the new world order, though.

Turn it into a GPL export while at it, since this is all about internal
interfaces and MOL is GPL'd anwyay.

 arch/ppc/kernel/ppc_ksyms.c |2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/ppc/kernel/ppc_ksyms.c b/arch/ppc/kernel/ppc_ksyms.c
--- a/arch/ppc/kernel/ppc_ksyms.c
+++ b/arch/ppc/kernel/ppc_ksyms.c
@@ -324,7 +324,7 @@ EXPORT_SYMBOL(__res);
 
 EXPORT_SYMBOL(next_mmu_context);
 EXPORT_SYMBOL(set_context);
-EXPORT_SYMBOL(handle_mm_fault); /* For MOL */
+EXPORT_SYMBOL_GPL(__handle_mm_fault); /* For MOL */
 EXPORT_SYMBOL(disarm_decr);
 #ifdef CONFIG_PPC_STD_MMU
 extern long mol_trampoline;
-
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Add fakey 'deflateBound()' function to the in-kernel zlib routines

2005-08-06 Thread Linux Kernel Mailing List
tree d97d8f30f59ef99c82cf8a9a6fce3c08768b240c
parent 021a52ac70802a94e699badb52af9d0fa728d5cd
author Linus Torvalds <[EMAIL PROTECTED]> Sat, 06 Aug 2005 23:39:57 -0700
committer Linus Torvalds <[EMAIL PROTECTED]> Sat, 06 Aug 2005 23:39:57 -0700

Add fakey 'deflateBound()' function to the in-kernel zlib routines

It's not the real deflateBound() in newer zlib libraries, partly because
the upcoming usage of it won't have the "stream" available, so we can't
have the same interfaces anyway.

 include/linux/zlib.h |5 +
 1 files changed, 5 insertions(+)

diff --git a/include/linux/zlib.h b/include/linux/zlib.h
--- a/include/linux/zlib.h
+++ b/include/linux/zlib.h
@@ -506,6 +506,11 @@ extern int zlib_deflateReset (z_streamp 
stream state was inconsistent (such as zalloc or state being NULL).
 */
 
+static inline unsigned long deflateBound(unsigned long s)
+{
+   return s + ((s + 7) >> 3) + ((s + 63) >> 6) + 11;
+}
+
 extern int zlib_deflateParams (z_streamp strm, int level, int strategy);
 /*
  Dynamically update the compression level and compression strategy.  The
-
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Bluetooth] Remove unused functions and cleanup symbol exports

2005-08-06 Thread Linux Kernel Mailing List
tree cf25ee6d3b555a246be9bf8b783d3a92325cf5d9
parent e9a3e671c09d419f29710d8620ed916d3bf7d7ab
author Marcel Holtmann <[EMAIL PROTECTED]> Sat, 06 Aug 2005 12:36:51 +0200
committer Marcel Holtmann <[EMAIL PROTECTED]> Sat, 06 Aug 2005 12:36:51 +0200

[Bluetooth] Remove unused functions and cleanup symbol exports

This patch removes the unused bt_dump() function and it also removes
its BT_DMP macro. It also unexports the hci_dev_get(), hci_send_cmd()
and hci_si_event() functions.

Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
Signed-off-by: Marcel Holtmann <[EMAIL PROTECTED]>

 drivers/bluetooth/hci_bcsp.c  |2 --
 drivers/bluetooth/hci_h4.c|5 -
 drivers/bluetooth/hci_ldisc.c |2 --
 drivers/bluetooth/hci_usb.c   |2 --
 include/net/bluetooth/bluetooth.h |8 
 net/bluetooth/hci_core.c  |2 --
 net/bluetooth/hci_event.c |1 -
 net/bluetooth/lib.c   |   25 -
 8 files changed, 47 deletions(-)

diff --git a/drivers/bluetooth/hci_bcsp.c b/drivers/bluetooth/hci_bcsp.c
--- a/drivers/bluetooth/hci_bcsp.c
+++ b/drivers/bluetooth/hci_bcsp.c
@@ -58,8 +58,6 @@
 #ifndef CONFIG_BT_HCIUART_DEBUG
 #undef  BT_DBG
 #define BT_DBG( A... )
-#undef  BT_DMP
-#define BT_DMP( A... )
 #endif
 
 static int hciextn = 1;
diff --git a/drivers/bluetooth/hci_h4.c b/drivers/bluetooth/hci_h4.c
--- a/drivers/bluetooth/hci_h4.c
+++ b/drivers/bluetooth/hci_h4.c
@@ -57,8 +57,6 @@
 #ifndef CONFIG_BT_HCIUART_DEBUG
 #undef  BT_DBG
 #define BT_DBG( A... )
-#undef  BT_DMP
-#define BT_DMP( A... )
 #endif
 
 /* Initialize protocol */
@@ -125,7 +123,6 @@ static inline int h4_check_data_len(stru
 
BT_DBG("len %d room %d", len, room);
if (!len) {
-   BT_DMP(h4->rx_skb->data, h4->rx_skb->len);
hci_recv_frame(h4->rx_skb);
} else if (len > room) {
BT_ERR("Data length is too large");
@@ -169,8 +166,6 @@ static int h4_recv(struct hci_uart *hu, 
case H4_W4_DATA:
BT_DBG("Complete data");
 
-   BT_DMP(h4->rx_skb->data, h4->rx_skb->len);
-
hci_recv_frame(h4->rx_skb);
 
h4->rx_state = H4_W4_PACKET_TYPE;
diff --git a/drivers/bluetooth/hci_ldisc.c b/drivers/bluetooth/hci_ldisc.c
--- a/drivers/bluetooth/hci_ldisc.c
+++ b/drivers/bluetooth/hci_ldisc.c
@@ -57,8 +57,6 @@
 #ifndef CONFIG_BT_HCIUART_DEBUG
 #undef  BT_DBG
 #define BT_DBG( A... )
-#undef  BT_DMP
-#define BT_DMP( A... )
 #endif
 
 static int reset = 0;
diff --git a/drivers/bluetooth/hci_usb.c b/drivers/bluetooth/hci_usb.c
--- a/drivers/bluetooth/hci_usb.c
+++ b/drivers/bluetooth/hci_usb.c
@@ -57,8 +57,6 @@
 #ifndef CONFIG_BT_HCIUSB_DEBUG
 #undef  BT_DBG
 #define BT_DBG(D...)
-#undef  BT_DMP
-#define BT_DMP(D...)
 #endif
 
 #ifndef CONFIG_BT_HCIUSB_ZERO_PACKET
diff --git a/include/net/bluetooth/bluetooth.h 
b/include/net/bluetooth/bluetooth.h
--- a/include/net/bluetooth/bluetooth.h
+++ b/include/net/bluetooth/bluetooth.h
@@ -57,12 +57,6 @@
 #define BT_DBG(fmt, arg...)  printk(KERN_INFO "%s: " fmt "\n" , __FUNCTION__ , 
## arg)
 #define BT_ERR(fmt, arg...)  printk(KERN_ERR  "%s: " fmt "\n" , __FUNCTION__ , 
## arg)
 
-#ifdef HCI_DATA_DUMP
-#define BT_DMP(buf, len) bt_dump(__FUNCTION__, buf, len)
-#else
-#define BT_DMP(D...)
-#endif
-
 extern struct proc_dir_entry *proc_bt;
 
 /* Connection and socket states */
@@ -174,8 +168,6 @@ static inline int skb_frags_no(struct sk
return n;
 }
 
-void bt_dump(char *pref, __u8 *buf, int count);
-
 int bt_err(__u16 code);
 
 #endif /* __BLUETOOTH_H */
diff --git a/net/bluetooth/hci_core.c b/net/bluetooth/hci_core.c
--- a/net/bluetooth/hci_core.c
+++ b/net/bluetooth/hci_core.c
@@ -299,7 +299,6 @@ struct hci_dev *hci_dev_get(int index)
read_unlock(&hci_dev_list_lock);
return hdev;
 }
-EXPORT_SYMBOL(hci_dev_get);
 
 /*  Inquiry support  */
 static void inquiry_cache_flush(struct hci_dev *hdev)
@@ -1042,7 +1041,6 @@ int hci_send_cmd(struct hci_dev *hdev, _
 
return 0;
 }
-EXPORT_SYMBOL(hci_send_cmd);
 
 /* Get data from the previously sent command */
 void *hci_sent_cmd_data(struct hci_dev *hdev, __u16 ogf, __u16 ocf)
diff --git a/net/bluetooth/hci_event.c b/net/bluetooth/hci_event.c
--- a/net/bluetooth/hci_event.c
+++ b/net/bluetooth/hci_event.c
@@ -1040,4 +1040,3 @@ void hci_si_event(struct hci_dev *hdev, 
hci_send_to_sock(hdev, skb);
kfree_skb(skb);
 }
-EXPORT_SYMBOL(hci_si_event);
diff --git a/net/bluetooth/lib.c b/net/bluetooth/lib.c
--- a/net/bluetooth/lib.c
+++ b/net/bluetooth/lib.c
@@ -34,31 +34,6 @@
 
 #include 
 
-void bt_dump(char *pref, __u8 *buf, int count)
-{
-   char *ptr;
-   char line[100];
-   unsigned int i;
-
-   printk(KERN_INFO "%s: dump, len %d\n", pref, count);
-
-   ptr = line;
-   *ptr = 0;
-   for (i = 0; i < count; i++) {
-   ptr += sprintf

[PATCH] ppc32: ppc440 pagetable attributes (comments updates)

2005-08-06 Thread Linux Kernel Mailing List
tree 6fb066dd3cd2e4423bdcfd8fc520a762d4848f27
parent 534afb90a9cd0b9643f62d660c164e1d924f39cf
author Matt Porter <[EMAIL PROTECTED]> Sat, 06 Aug 2005 21:21:06 -0700
committer Linus Torvalds <[EMAIL PROTECTED]> Sat, 06 Aug 2005 23:23:57 -0700

[PATCH] ppc32: ppc440 pagetable attributes (comments updates)

Here's an incremental patch with comment updates and some additional
grammar cleanups.

Signed-off-by: Matt Porter <[EMAIL PROTECTED]>
Signed-off-by: Linus Torvalds <[EMAIL PROTECTED]>

 include/asm-ppc/pgtable.h |   26 +-
 1 files changed, 13 insertions(+), 13 deletions(-)

diff --git a/include/asm-ppc/pgtable.h b/include/asm-ppc/pgtable.h
--- a/include/asm-ppc/pgtable.h
+++ b/include/asm-ppc/pgtable.h
@@ -227,21 +227,21 @@ extern unsigned long ioremap_bot, iorema
  * doesn't support SMP. So we can use this as software bit, like
  * DIRTY.
  *
- * PPC Book-E Linux implementation uses PPC HW PTE bit field definition,
- * even it doesn't have HW PTE. 0-11th LSB of PTE stand for memory
- * protection-related function. (See PTE structure in include/asm-ppc/mmu.h)
- * Definition of _PAGE_XXX in "include/asm-ppc/pagetable.h" stands for
- * above bits. Note that those bits values are CPU dependent, not
- * architecture.
+ * With the PPC 44x Linux implementation, the 0-11th LSBs of the PTE are used
+ * for memory protection related functions (see PTE structure in
+ * include/asm-ppc/mmu.h).  The _PAGE_XXX definitions in this file map to the
+ * above bits.  Note that the bit values are CPU specific, not architecture
+ * specific.
  *
- * Kernel PTE entry holds arch-dependent swp_entry structure under certain
- * situation. In other words, in such situation, some portion of PTE bits
- * are used as swp_entry. In PPC implementation, 3-24th LSB are shared with
- * swp_entry, however 0-2nd three LSB still hold protection values.
- * That means three protection bits are reserved for both PTE and SWAP
- * entry at the most three LSBs.
+ * The kernel PTE entry holds an arch-dependent swp_entry structure under
+ * certain situations. In other words, in such situations some portion of
+ * the PTE bits are used as a swp_entry. In the PPC implementation, the
+ * 3-24th LSB are shared with swp_entry, however the 0-2nd three LSB still
+ * hold protection values. That means the three protection bits are
+ * reserved for both PTE and SWAP entry at the most significant three
+ * LSBs.
  *
- * There are three protection bits available for SWAP entry;
+ * There are three protection bits available for SWAP entry:
  * _PAGE_PRESENT
  * _PAGE_FILE
  * _PAGE_HASHPTE (if HW has)
-
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Bluetooth] Add direction and timestamp to stack internal events

2005-08-06 Thread Linux Kernel Mailing List
tree 0a1241104c7a52323425a3f6930163340e2d0829
parent 66e8b6c31b9254243afaac8af4135e84e11dd38e
author Marcel Holtmann <[EMAIL PROTECTED]> Sat, 06 Aug 2005 12:36:54 +0200
committer Marcel Holtmann <[EMAIL PROTECTED]> Sat, 06 Aug 2005 12:36:54 +0200

[Bluetooth] Add direction and timestamp to stack internal events

This patch changes the direction to incoming and adds the timestamp
to all stack internal events.

Signed-off-by: Marcel Holtmann <[EMAIL PROTECTED]>

 net/bluetooth/hci_event.c |3 +++
 1 files changed, 3 insertions(+)

diff --git a/net/bluetooth/hci_event.c b/net/bluetooth/hci_event.c
--- a/net/bluetooth/hci_event.c
+++ b/net/bluetooth/hci_event.c
@@ -1035,6 +1035,9 @@ void hci_si_event(struct hci_dev *hdev, 
ev->type = type;
memcpy(ev->data, data, dlen);
 
+   bt_cb(skb)->incoming = 1;
+   do_gettimeofday(&skb->stamp);
+
skb->pkt_type = HCI_EVENT_PKT;
skb->dev = (void *) hdev;
hci_send_to_sock(hdev, skb);
-
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Bluetooth] Revert session reference counting fix

2005-08-06 Thread Linux Kernel Mailing List
tree 45872ffc48be8319a88259cfcef86605a1f94a4e
parent cad0f6270c0bae5bcae6af3c7ac7bd3ae5d9b618
author Marcel Holtmann <[EMAIL PROTECTED]> Sat, 06 Aug 2005 12:36:42 +0200
committer Marcel Holtmann <[EMAIL PROTECTED]> Sat, 06 Aug 2005 12:36:42 +0200

[Bluetooth] Revert session reference counting fix

The fix for the reference counting problem of the signal DLC introduced
a race condition which leads to an oops. The reason for it is not fully
understood by now and so revert this fix, because the reference counting
problem is not crashing the RFCOMM layer and its appearance it rare.

Signed-off-by: Marcel Holtmann <[EMAIL PROTECTED]>

 net/bluetooth/rfcomm/core.c |4 
 1 files changed, 4 deletions(-)

diff --git a/net/bluetooth/rfcomm/core.c b/net/bluetooth/rfcomm/core.c
--- a/net/bluetooth/rfcomm/core.c
+++ b/net/bluetooth/rfcomm/core.c
@@ -389,8 +389,6 @@ static int __rfcomm_dlc_close(struct rfc
rfcomm_dlc_unlock(d);
 
skb_queue_purge(&d->tx_queue);
-   rfcomm_session_put(s);
-
rfcomm_dlc_unlink(d);
}
 
@@ -600,8 +598,6 @@ static struct rfcomm_session *rfcomm_ses
goto failed;
}
 
-   rfcomm_session_hold(s);
-
s->initiator = 1;
 
bacpy(&addr.l2_bdaddr, dst);
-
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Bluetooth] Kill redundant NULL checks before kfree()

2005-08-06 Thread Linux Kernel Mailing List
tree 6ce4e75810fc0724d05c305fc6b517aba23598c0
parent dcc365d8f28d6a2332fa37e64d669858a8d017e8
author Marcel Holtmann <[EMAIL PROTECTED]> Sat, 06 Aug 2005 12:36:47 +0200
committer Marcel Holtmann <[EMAIL PROTECTED]> Sat, 06 Aug 2005 12:36:47 +0200

[Bluetooth] Kill redundant NULL checks before kfree()

There's no need to check for NULL before calling kfree() on a pointer.

Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
Signed-off-by: Marcel Holtmann <[EMAIL PROTECTED]>

 drivers/bluetooth/bpa10x.c  |7 ++-
 drivers/bluetooth/hci_usb.c |6 ++
 2 files changed, 4 insertions(+), 9 deletions(-)

diff --git a/drivers/bluetooth/bpa10x.c b/drivers/bluetooth/bpa10x.c
--- a/drivers/bluetooth/bpa10x.c
+++ b/drivers/bluetooth/bpa10x.c
@@ -367,11 +367,8 @@ static inline void bpa10x_free_urb(struc
if (!urb)
return;
 
-   if (urb->setup_packet)
-   kfree(urb->setup_packet);
-
-   if (urb->transfer_buffer)
-   kfree(urb->transfer_buffer);
+   kfree(urb->setup_packet);
+   kfree(urb->transfer_buffer);
 
usb_free_urb(urb);
 }
diff --git a/drivers/bluetooth/hci_usb.c b/drivers/bluetooth/hci_usb.c
--- a/drivers/bluetooth/hci_usb.c
+++ b/drivers/bluetooth/hci_usb.c
@@ -390,10 +390,8 @@ static void hci_usb_unlink_urbs(struct h
urb = &_urb->urb;
BT_DBG("%s freeing _urb %p type %d urb %p",
husb->hdev->name, _urb, _urb->type, 
urb);
-   if (urb->setup_packet)
-   kfree(urb->setup_packet);
-   if (urb->transfer_buffer)
-   kfree(urb->transfer_buffer);
+   kfree(urb->setup_packet);
+   kfree(urb->transfer_buffer);
_urb_free(_urb);
}
 
-
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Bluetooth] Send HCI_Reset for Kensington dongle

2005-08-06 Thread Linux Kernel Mailing List
tree 958f349daed2ad3e1f4c97e94aabbef3c30c1d82
parent 534afb90a9cd0b9643f62d660c164e1d924f39cf
author Marcel Holtmann <[EMAIL PROTECTED]> Sat, 06 Aug 2005 12:36:36 +0200
committer Marcel Holtmann <[EMAIL PROTECTED]> Sat, 06 Aug 2005 12:36:36 +0200

[Bluetooth] Send HCI_Reset for Kensington dongle

The Kensington Bluetooth USB adapter is based on a Broadcom chip
with the HID proxy support. To initialize these kind of devices
correctly it is necessary to send HCI_Reset as the first command.

Signed-off-by: Marcel Holtmann <[EMAIL PROTECTED]>

 drivers/bluetooth/hci_usb.c |3 +++
 1 files changed, 3 insertions(+)

diff --git a/drivers/bluetooth/hci_usb.c b/drivers/bluetooth/hci_usb.c
--- a/drivers/bluetooth/hci_usb.c
+++ b/drivers/bluetooth/hci_usb.c
@@ -110,6 +110,9 @@ static struct usb_device_id blacklist_id
/* Microsoft Wireless Transceiver for Bluetooth 2.0 */
{ USB_DEVICE(0x045e, 0x009c), .driver_info = HCI_RESET },
 
+   /* Kensington Bluetooth USB adapter */
+   { USB_DEVICE(0x047d, 0x105d), .driver_info = HCI_RESET },
+
/* ISSC Bluetooth Adapter v3.1 */
{ USB_DEVICE(0x1131, 0x1001), .driver_info = HCI_RESET },
 
-
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html