[GitHub] [activemq-artemis] michaelpearce-gain commented on issue #2750: ARTEMIS-2399 Improve performance when there are a lot of subscribers
michaelpearce-gain commented on issue #2750: ARTEMIS-2399 Improve performance when there are a lot of subscribers URL: https://github.com/apache/activemq-artemis/pull/2750#issuecomment-514906870 I would use separate pr and as we haven't released yet. Even use that original jira to fix #2740 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] jdanekrh commented on issue #2767: ARTEMIS-2431: Test to reproduce the pipelined open auth issue with AMQP
jdanekrh commented on issue #2767: ARTEMIS-2431: Test to reproduce the pipelined open auth issue with AMQP URL: https://github.com/apache/activemq-artemis/pull/2767#issuecomment-514895884 I'll close the PR, then, and leave just the branch with currently failing test. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] jdanekrh closed pull request #2767: ARTEMIS-2431: Test to reproduce the pipelined open auth issue with AMQP
jdanekrh closed pull request #2767: ARTEMIS-2431: Test to reproduce the pipelined open auth issue with AMQP URL: https://github.com/apache/activemq-artemis/pull/2767 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] wy96f commented on issue #2750: ARTEMIS-2399 Improve performance when there are a lot of subscribers
wy96f commented on issue #2750: ARTEMIS-2399 Improve performance when there are a lot of subscribers URL: https://github.com/apache/activemq-artemis/pull/2750#issuecomment-514875375 > I will need some time to review this last week. > > Can you rebase again after I merged your change? I'm working on PageReader per queue these days. Unluckily some problem was encountered. After investigation, I found it was related to #2740 which would sync files while closing. Given we put PageReader in PageSubscription meaning 100 times of file open/close for each page in our case(100 queues), although page file is only opened for reading, the sync operation does cause great performance loss - ~5000 msg/s received and 13000 msg/s sent now compared with 16000 msg/s received and 11000 msg/s sent of pr. Should I file a new jira and pr to fix the problem introuduced by #2740 or just fix it in this one? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] clebertsuconic commented on issue #2750: ARTEMIS-2399 Improve performance when there are a lot of subscribers
clebertsuconic commented on issue #2750: ARTEMIS-2399 Improve performance when there are a lot of subscribers URL: https://github.com/apache/activemq-artemis/pull/2750#issuecomment-514870176 I will need some time to review this last week. Can you rebase again after I merged your change? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] clebertsuconic commented on issue #2767: ARTEMIS-2431: Test to reproduce the pipelined open auth issue with AMQP
clebertsuconic commented on issue #2767: ARTEMIS-2431: Test to reproduce the pipelined open auth issue with AMQP URL: https://github.com/apache/activemq-artemis/pull/2767#issuecomment-514870002 I'm not sure it's a good idea to add a failing test without a fix already. You could just open a JIRA, and add the test with a branch reference, a patch.. or anything like that. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] jdanekrh opened a new pull request #2767: ARTEMIS-2431: Test to reproduce the pipelined open auth issue with AMQP
jdanekrh opened a new pull request #2767: ARTEMIS-2431: Test to reproduce the pipelined open auth issue with AMQP URL: https://github.com/apache/activemq-artemis/pull/2767 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] wy96f opened a new pull request #2766: ARTEMIS-2430 Avoid data loss when live page cache evicted
wy96f opened a new pull request #2766: ARTEMIS-2430 Avoid data loss when live page cache evicted URL: https://github.com/apache/activemq-artemis/pull/2766 When live page cache is cleared by gc, partially written page cache would be returned causing subsequent written messages lost. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
