[GitHub] [activemq-artemis] asfgit closed pull request #2784: NO-JIRA Remove wrong parenthesis in upgrading step
asfgit closed pull request #2784: NO-JIRA Remove wrong parenthesis in upgrading step URL: https://github.com/apache/activemq-artemis/pull/2784 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] asfgit merged pull request #2786: ARTEMIS-2440 Call timeout should retry the connection asynchronously
asfgit merged pull request #2786: ARTEMIS-2440 Call timeout should retry the connection asynchronously URL: https://github.com/apache/activemq-artemis/pull/2786 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] TonyJulin commented on issue #2779: ARTEMIS-2444 Artemis hawtio plugin overriding sublevel tabs
TonyJulin commented on issue #2779: ARTEMIS-2444 Artemis hawtio plugin overriding sublevel tabs URL: https://github.com/apache/activemq-artemis/pull/2779#issuecomment-518304881 Opened a JIRA issue and ammended the commit message. Let me know if those work. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] clebertsuconic opened a new pull request #2786: ARTEMIS-2440 Call timeout should retry the connection asynchronously
clebertsuconic opened a new pull request #2786: ARTEMIS-2440 Call timeout should retry the connection asynchronously URL: https://github.com/apache/activemq-artemis/pull/2786 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] asfgit merged pull request #2782: ARTEMIS-2441 Separate Lock Files
asfgit merged pull request #2782: ARTEMIS-2441 Separate Lock Files URL: https://github.com/apache/activemq-artemis/pull/2782 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull request #2782: ARTEMIS-2441 Separate Lock Files
clebertsuconic commented on a change in pull request #2782: ARTEMIS-2441
Separate Lock Files
URL: https://github.com/apache/activemq-artemis/pull/2782#discussion_r310603307
##
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/FileLockNodeManager.java
##
@@ -82,6 +86,36 @@ public synchronized void start() throws Exception {
super.start();
}
+ @Override
+ protected synchronized void setUpServerLockFile() throws IOException {
+ super.setUpServerLockFile();
+
+ for (int i = 0; i < 3; i++) {
+ if (lockChannels[i] != null && lockChannels[i].isOpen()) {
+continue;
+ }
+ File fileLock = newFile("serverlock." + i);
+ if (!fileLock.exists()) {
+fileLock.createNewFile();
+ }
+ RandomAccessFile randomFileLock = new RandomAccessFile(fileLock,
"rw");
+ lockChannels[i] = randomFileLock.getChannel();
+ }
+ }
+
+ @Override
+ public synchronized void stop() throws Exception {
+ for (FileChannel channel : lockChannels) {
+ try {
+channel.close();
+ } catch (Throwable e) {
+
Review comment:
hmmm... I should have logged it here. (reviewing my own PR)
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] clebertsuconic commented on issue #2783: Treat empty providerUrl string same way as null value.
clebertsuconic commented on issue #2783: Treat empty providerUrl string same way as null value. URL: https://github.com/apache/activemq-artemis/pull/2783#issuecomment-518232524 @Premik sounds a good place. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] franz1981 commented on issue #2750: ARTEMIS-2399 Improve performance when there are a lot of subscribers
franz1981 commented on issue #2750: ARTEMIS-2399 Improve performance when there are a lot of subscribers URL: https://github.com/apache/activemq-artemis/pull/2750#issuecomment-518197382 @wy96f > it's possible the pages are constantly dropping in an out while consumers are cathing up, resulting in performance drop Yep, but that would affect both consumer(s) and producers, not just producers: anyway I'm struggling to reproduce it reliably, so probably will dig into it much further before checking with this PR :+1: > In our test consumers were falling behind producers all the time. I saw ~80GB page files left after test lasting 1 hour. And while catching up, the producers are not seriously decreasing their rate? This PR has helped in your tests? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] wy96f opened a new pull request #2785: ARTEMIS-2442 throw ActiveMQResourceLimitException if session/queue limit is reached
wy96f opened a new pull request #2785: ARTEMIS-2442 throw ActiveMQResourceLimitException if session/queue limit is reached URL: https://github.com/apache/activemq-artemis/pull/2785 Now ActiveMQSessionCreationException is thrown when session/queue limit is reached. ActiveMQSessionCreationException is used to indicate server is starting. It would cause session recreation retries all the time. Session creation should fail fast when limit is reached so client can try to connect other brokers in cluster. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] bs-logisoft opened a new pull request #2784: NO-JIRA Remove wrong parenthesis in upgrading step
bs-logisoft opened a new pull request #2784: NO-JIRA Remove wrong parenthesis in upgrading step URL: https://github.com/apache/activemq-artemis/pull/2784 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] wy96f commented on issue #2750: ARTEMIS-2399 Improve performance when there are a lot of subscribers
wy96f commented on issue #2750: ARTEMIS-2399 Improve performance when there are a lot of subscribers URL: https://github.com/apache/activemq-artemis/pull/2750#issuecomment-518139732 @franz1981 In our test consumers were falling behind producers all the time. I saw ~80GB page files left after test lasting 1 hour. I'm not sure whether it's related to this pr. Considering 10GB page data produced, it's possible the pages are constantly dropping in an out while consumers are cathing up, resulting in performance drop. Could you try this pr to check it? :) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-nms-amqp] HavretGC edited a comment on issue #8: AMQNET-591: Transactions support
HavretGC edited a comment on issue #8: AMQNET-591: Transactions support URL: https://github.com/apache/activemq-nms-amqp/pull/8#issuecomment-518138461 @michaelandrepearce TBH I'm not sure if it can be done that way, as TransactionId is part of the Transfer frame, and not the payload itself, thus we don't have access to it. It's part of amqpnetlite internals. Moreover I don't see this being exposed in qpid jms either. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-nms-amqp] HavretGC commented on issue #8: AMQNET-591: Transactions support
HavretGC commented on issue #8: AMQNET-591: Transactions support URL: https://github.com/apache/activemq-nms-amqp/pull/8#issuecomment-518138461 @michaelandrepearce TBH I'm not sure if it can be done that way, as TransactionId is part of the Transfer frame, and not the payload itself, thus we don't have access to it. It's part of amqpnetlite internals. I don't see this exposed in qpid jms either. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-nms-amqp] HavretGC edited a comment on issue #8: AMQNET-591: Transactions support
HavretGC edited a comment on issue #8: AMQNET-591: Transactions support URL: https://github.com/apache/activemq-nms-amqp/pull/8#issuecomment-518138461 @michaelandrepearce TBH I'm not sure if it can be done that way, as TransactionId is part of the Transfer frame, and not the payload itself, thus we don't have access to it. It's part of amqpnetlite internals. Moreover I don't see this exposed in qpid jms either. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] franz1981 commented on issue #2750: ARTEMIS-2399 Improve performance when there are a lot of subscribers
franz1981 commented on issue #2750: ARTEMIS-2399 Improve performance when there are a lot of subscribers URL: https://github.com/apache/activemq-artemis/pull/2750#issuecomment-518129069 > Be great to have a recreator. Will work on provide one soon > Also if in master already its unrelated to the work here (eg this work causes no regression in perf). I would like to avoid conflating issues That's a good point: although I've hoped that would be kinda related to the work done here, but I see that is a different scenario...will move the discuttion into the dev list, thanks :+1: This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] michaelandrepearce edited a comment on issue #2750: ARTEMIS-2399 Improve performance when there are a lot of subscribers
michaelandrepearce edited a comment on issue #2750: ARTEMIS-2399 Improve performance when there are a lot of subscribers URL: https://github.com/apache/activemq-artemis/pull/2750#issuecomment-518126703 are you sure its not underlying disk/infra issue, im very surprised by scenario you explain. Be great to have a recreator. Also if in master already its unrelated to the work here (eg this work causes no regression in perf). I would like to avoid conflating issues This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] franz1981 edited a comment on issue #2750: ARTEMIS-2399 Improve performance when there are a lot of subscribers
franz1981 edited a comment on issue #2750: ARTEMIS-2399 Improve performance when there are a lot of subscribers URL: https://github.com/apache/activemq-artemis/pull/2750#issuecomment-518124124 @michaelandrepearce I'm using the latest master: my concern is that during `PagingStoreImpl::page` we perform both `storageManagerLock.readLock::lock` and `PagingStoreImpl.lock.writeLock::lock`...so maybe there are consuming operations that prevent these locks to be released This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] franz1981 commented on issue #2750: ARTEMIS-2399 Improve performance when there are a lot of subscribers
franz1981 commented on issue #2750: ARTEMIS-2399 Improve performance when there are a lot of subscribers URL: https://github.com/apache/activemq-artemis/pull/2750#issuecomment-518124124 @michaelandrepearce I'm using the latest master: my concern is that during `PagingStoreImpl::page` we perform both `storageManagerLock.readLock` and `PagingStoreImpl.lock.writeLock::lock`...so maybe there are consuming operations that prevent these locks to be released This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-nms-amqp] michaelandrepearce merged pull request #13: AMQNET-595: Set and get group-id message property field
michaelandrepearce merged pull request #13: AMQNET-595: Set and get group-id message property field URL: https://github.com/apache/activemq-nms-amqp/pull/13 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-nms-amqp] michaelandrepearce commented on a change in pull request #13: AMQNET-595: Set and get group-id message property field
michaelandrepearce commented on a change in pull request #13: AMQNET-595: Set
and get group-id message property field
URL: https://github.com/apache/activemq-nms-amqp/pull/13#discussion_r310471850
##
File path: src/NMS.AMQP/Message/NmsMessage.cs
##
@@ -94,13 +94,19 @@ public string NMSType
get => Facade.NMSType;
set => Facade.NMSType = value;
}
-
-public string NMSGroupId
+
+public string NMSXGroupId
{
get => Facade.GroupId;
set => Facade.GroupId = value;
}
+public int NMSXGroupSeq
Review comment:
Test case for sequence?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-nms-amqp] michaelandrepearce commented on a change in pull request #13: AMQNET-595: Set and get group-id message property field
michaelandrepearce commented on a change in pull request #13: AMQNET-595: Set
and get group-id message property field
URL: https://github.com/apache/activemq-nms-amqp/pull/13#discussion_r310471850
##
File path: src/NMS.AMQP/Message/NmsMessage.cs
##
@@ -94,13 +94,19 @@ public string NMSType
get => Facade.NMSType;
set => Facade.NMSType = value;
}
-
-public string NMSGroupId
+
+public string NMSXGroupId
{
get => Facade.GroupId;
set => Facade.GroupId = value;
}
+public int NMSXGroupSeq
Review comment:
Test case for sequence?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-nms-amqp] HavretGC commented on a change in pull request #13: AMQNET-595: Set and get group-id message property field
HavretGC commented on a change in pull request #13: AMQNET-595: Set and get
group-id message property field
URL: https://github.com/apache/activemq-nms-amqp/pull/13#discussion_r310471057
##
File path: src/NMS.AMQP/Provider/Amqp/Message/AmqpNmsMessageFacade.cs
##
@@ -436,6 +436,12 @@ protected void CopyInto(AmqpNmsMessageFacade target)
target.destination = destination;
target.replyTo = replyTo;
+// Workaround for https://github.com/Azure/amqpnetlite/pull/364
+if (Message.BodySection is AmqpValue value)
+{
Review comment:
No, it shouldn't be here. I've just cleaned it up.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-nms-amqp] HavretGC commented on a change in pull request #13: AMQNET-595: Set and get group-id message property field
HavretGC commented on a change in pull request #13: AMQNET-595: Set and get
group-id message property field
URL: https://github.com/apache/activemq-nms-amqp/pull/13#discussion_r310471057
##
File path: src/NMS.AMQP/Provider/Amqp/Message/AmqpNmsMessageFacade.cs
##
@@ -436,6 +436,12 @@ protected void CopyInto(AmqpNmsMessageFacade target)
target.destination = destination;
target.replyTo = replyTo;
+// Workaround for https://github.com/Azure/amqpnetlite/pull/364
+if (Message.BodySection is AmqpValue value)
+{
Review comment:
No, it shouldn't be here. Just cleaned it up.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-nms-amqp] michaelandrepearce commented on issue #8: AMQNET-591: Transactions support
michaelandrepearce commented on issue #8: AMQNET-591: Transactions support URL: https://github.com/apache/activemq-nms-amqp/pull/8#issuecomment-518121497 Can we check with openwire if we are exposing the nmsx extension parameters for transaction the same This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-nms-amqp] michaelandrepearce commented on a change in pull request #13: AMQNET-595: Set and get group-id message property field
michaelandrepearce commented on a change in pull request #13: AMQNET-595: Set
and get group-id message property field
URL: https://github.com/apache/activemq-nms-amqp/pull/13#discussion_r310470259
##
File path: src/NMS.AMQP/Provider/Amqp/Message/AmqpNmsMessageFacade.cs
##
@@ -436,6 +436,12 @@ protected void CopyInto(AmqpNmsMessageFacade target)
target.destination = destination;
target.replyTo = replyTo;
+// Workaround for https://github.com/Azure/amqpnetlite/pull/364
+if (Message.BodySection is AmqpValue value)
+{
Review comment:
Did you mean to re add this
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-nms-amqp] HavretGC opened a new pull request #13: AMQNET-595: Set and get group-id message property field
HavretGC opened a new pull request #13: AMQNET-595: Set and get group-id message property field URL: https://github.com/apache/activemq-nms-amqp/pull/13 This addresses https://github.com/apache/activemq-nms-amqp/pull/12#issuecomment-518114059 Moreover support for GroupSequence was added. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] michaelandrepearce commented on issue #2750: ARTEMIS-2399 Improve performance when there are a lot of subscribers
michaelandrepearce commented on issue #2750: ARTEMIS-2399 Improve performance when there are a lot of subscribers URL: https://github.com/apache/activemq-artemis/pull/2750#issuecomment-518116101 @franz1981 what version was that in. I know alot of locking changes to improve that had been made already to alleviate that. Do you get that still in latest? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] Premik commented on issue #2783: Treat empty providerUrl string same way as null value.
Premik commented on issue #2783: Treat empty providerUrl string same way as null value. URL: https://github.com/apache/activemq-artemis/pull/2783#issuecomment-518114993 Would the `/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/SimpleJNDIClientTest.java` be a good place to add the test to? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-nms-amqp] michaelandrepearce commented on issue #12: AMQNET-595: Set and get group-id message property field
michaelandrepearce commented on issue #12: AMQNET-595: Set and get group-id message property field URL: https://github.com/apache/activemq-nms-amqp/pull/12#issuecomment-518114950 https://github.com/apache/activemq-nms-openwire/blob/master/src/main/csharp/Commands/ActiveMQMessage.cs Please see NMS Extensions. Also can we make sure the other NMSX are named appropriately. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] franz1981 commented on issue #2750: ARTEMIS-2399 Improve performance when there are a lot of subscribers
franz1981 commented on issue #2750: ARTEMIS-2399 Improve performance when there are a lot of subscribers URL: https://github.com/apache/activemq-artemis/pull/2750#issuecomment-518114338 @michaelandrepearce > which test? Just a specific scenario I've been fallen into recently, to summarize it: - a topic with many publishers sending durable messages - many durable subscribers - 1 of the subscribers disconnect for some time - publishers start paging - after 10 GB of paged data, the subscriber come back online again - while it catches up, the other publishers/subscribers rate are seriously affected (approaching to 1/2 msg/sec) - when it catches up, things come back normal for everyone This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] michaelandrepearce edited a comment on issue #2750: ARTEMIS-2399 Improve performance when there are a lot of subscribers
michaelandrepearce edited a comment on issue #2750: ARTEMIS-2399 Improve performance when there are a lot of subscribers URL: https://github.com/apache/activemq-artemis/pull/2750#issuecomment-518112452 @franz1981 which test? I know when we page producers slow down this is because of the extra io as goes to paging not memory, which is side effect of paging, and ideally why its good to avoid. Just want to make sure its not that This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq] jbonofre opened a new pull request #381: [AMQ-7254] Fix OSGi headers
jbonofre opened a new pull request #381: [AMQ-7254] Fix OSGi headers URL: https://github.com/apache/activemq/pull/381 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
