[GitHub] [activemq-artemis] franz1981 commented on issue #2793: ARTEMIS-2452 group-name ignored in shared store colocated setup
franz1981 commented on issue #2793: ARTEMIS-2452 group-name ignored in shared store colocated setup URL: https://github.com/apache/activemq-artemis/pull/2793#issuecomment-521563027 Yes, sure and will provide proper yes and coverage too as it deserves :) Thanks for the suggestions Michael!! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] franz1981 commented on issue #2793: ARTEMIS-2452 group-name ignored in shared store colocated setup
franz1981 commented on issue #2793: ARTEMIS-2452 group-name ignored in shared store colocated setup URL: https://github.com/apache/activemq-artemis/pull/2793#issuecomment-521559226 I understand your comment now, my comment was related to the code itself,not the feature as a whole: I see that there exists cases where it can work.. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] franz1981 commented on issue #2793: ARTEMIS-2452 group-name ignored in shared store colocated setup
franz1981 commented on issue #2793: ARTEMIS-2452 group-name ignored in shared store colocated setup URL: https://github.com/apache/activemq-artemis/pull/2793#issuecomment-521557724 The feature of shared store colocated is not totally broken, but the shared store colocation using group names, yes. But is normal, if the were not using at all group names in their logic I believe that's ok.. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] franz1981 commented on issue #2793: ARTEMIS-2452 group-name ignored in shared store colocated setup
franz1981 commented on issue #2793: ARTEMIS-2452 group-name ignored in shared store colocated setup URL: https://github.com/apache/activemq-artemis/pull/2793#issuecomment-521556443 The version proposal is probably the best solution indeed: the reason why the old logic breaks the new one is that the old one just ignored the group names and let any requesting server that arrive first to be able to form a pair on any group name regardless both the requesting server group name and the target server. It was just totally broken... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] franz1981 commented on issue #2793: ARTEMIS-2452 group-name ignored in shared store colocated setup
franz1981 commented on issue #2793: ARTEMIS-2452 group-name ignored in shared store colocated setup URL: https://github.com/apache/activemq-artemis/pull/2793#issuecomment-520889867 @howardgao @jbertram wdyt? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] franz1981 commented on issue #2793: ARTEMIS-2452 group-name ignored in shared store colocated setup
franz1981 commented on issue #2793: ARTEMIS-2452 group-name ignored in shared store colocated setup URL: https://github.com/apache/activemq-artemis/pull/2793#issuecomment-520888383 This PR is adding `BackupRequestMessage`'s `nodeID` information for shared store colocated setup, to enable proper validation of backup group names: I don't know yet how to handle the case where old brokers are communicating with new ones, but throwing an exception + logging a warn message. I'm opened to other approaches ;) I will add some tests on my PTO return, but I've left this here to make it available for comment/reviewes :) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
