[GitHub] [activemq-artemis] jdanekrh commented on issue #2792: NO-JIRA: Javadoc for ActiveMQServerMessagePlugin interface
jdanekrh commented on issue #2792: NO-JIRA: Javadoc for ActiveMQServerMessagePlugin interface URL: https://github.com/apache/activemq-artemis/pull/2792#issuecomment-521680441 (Does it look reasonable so far, what I wrote? Especially that using ThreadLocal is a good idea?) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] jdanekrh commented on issue #2792: NO-JIRA: Javadoc for ActiveMQServerMessagePlugin interface
jdanekrh commented on issue #2792: NO-JIRA: Javadoc for ActiveMQServerMessagePlugin interface URL: https://github.com/apache/activemq-artemis/pull/2792#issuecomment-521549275 Ok, I can move it there. I saw some java classes with quite extensive Javadoc, and I felt that explaining how user provided methods are called belongs in a Javadoc. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] jdanekrh commented on issue #2792: NO-JIRA: Javadoc for ActiveMQServerMessagePlugin interface
jdanekrh commented on issue #2792: NO-JIRA: Javadoc for ActiveMQServerMessagePlugin interface URL: https://github.com/apache/activemq-artemis/pull/2792#issuecomment-520391046 I still need to try this with a broker cluster, to see what exactly happens there. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
