[GitHub] [activemq-artemis] michaelandrepearce edited a comment on issue #2793: ARTEMIS-2452 group-name ignored in shared store colocated setup

2019-08-23 Thread GitBox
michaelandrepearce edited a comment on issue #2793: ARTEMIS-2452 group-name 
ignored in shared store colocated setup
URL: https://github.com/apache/activemq-artemis/pull/2793#issuecomment-524365392
 
 
   @clebertsuconic its not ready for merge anyhow. Waiting on @franz1981 atm


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [activemq-artemis] michaelandrepearce edited a comment on issue #2793: ARTEMIS-2452 group-name ignored in shared store colocated setup

2019-08-15 Thread GitBox
michaelandrepearce edited a comment on issue #2793: ARTEMIS-2452 group-name 
ignored in shared store colocated setup
URL: https://github.com/apache/activemq-artemis/pull/2793#issuecomment-521556891
 
 
   Well it can't be totally broken, theres users out there using it (mostly 
because they are forming single groups or ensuring clusters are rign fenced, 
therefor group name isnt really mandatory there, yes theres a bug if you need 
multiple, and  thats not ideal, but its not totally broken as you say,


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [activemq-artemis] michaelandrepearce edited a comment on issue #2793: ARTEMIS-2452 group-name ignored in shared store colocated setup

2019-08-15 Thread GitBox
michaelandrepearce edited a comment on issue #2793: ARTEMIS-2452 group-name 
ignored in shared store colocated setup
URL: https://github.com/apache/activemq-artemis/pull/2793#issuecomment-521552397
 
 
   Why not have a setting that makes it behave as old version, then once all 
servers uograded the setting can change to strict..making the flag dynamic 
would also mean the last change can be done without need for further bounces 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services