[GitHub] [activemq-nms-amqp] Havret edited a comment on issue #45: AMQNET-624: Fix failover issue when broker sends open frame and shortly after close frame
Havret edited a comment on issue #45: AMQNET-624: Fix failover issue when broker sends open frame and shortly after close frame URL: https://github.com/apache/activemq-nms-amqp/pull/45#issuecomment-547599630 @cjwmorgan-sol No it shouldn't. I've tried to reproduce what you did but with no luck. Nevertheless I've revoked the Task.Run change, as it shouldn't be part of this PR. With all that being said, I think we should revisit this part of code (mainly TriggerReconnectionAttempt) after we hopefully deliver the initial release. Calling async method without await or GetResult() is always a red flag. https://issues.apache.org/jira/browse/AMQNET-626 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-nms-amqp] Havret edited a comment on issue #45: AMQNET-624: Fix failover issue when broker sends open frame and shortly after close frame
Havret edited a comment on issue #45: AMQNET-624: Fix failover issue when broker sends open frame and shortly after close frame URL: https://github.com/apache/activemq-nms-amqp/pull/45#issuecomment-547599630 @cjwmorgan-sol No it shouldn't. I've tried to reproduce what you did but with no lack. Nevertheless I've revoked the Task.Run change, as it shouldn't be part of this PR. With all that being said, I think we should revisit this part of code (mainly TriggerReconnectionAttempt) after we hopefully deliver the initial release. Calling async method without await or GetResult() is always a red flag. https://issues.apache.org/jira/browse/AMQNET-626 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-nms-amqp] Havret edited a comment on issue #45: AMQNET-624: Fix failover issue when broker sends open frame and shortly after close frame
Havret edited a comment on issue #45: AMQNET-624: Fix failover issue when broker sends open frame and shortly after close frame URL: https://github.com/apache/activemq-nms-amqp/pull/45#issuecomment-547599630 @cjwmorgan-sol No it shouldn't. I've tried to reproduce what you did but with no lack. Nevertheless I've revoked the Task.Run change, as it shouldn't be part of this PR. With all that being said, I think we should revisit this part of code (mainly TriggerReconnectionAttempt) after we hopefully deliver the initial release. Calling async method without await or GetResult() is always a red flag. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
