[GitHub] [activemq-nms-amqp] michaelandrepearce edited a comment on issue #28: NO-JIRA: Extend logging

2019-09-13 Thread GitBox
michaelandrepearce edited a comment on issue #28: NO-JIRA: Extend logging
URL: https://github.com/apache/activemq-nms-amqp/pull/28#issuecomment-531367659
 
 
   Why would we log here? Exception here would be because exception was thrown 
within users message listener code. I would expect if it was important for a 
user to add their own logging as they see fit into their listener logic. As 
what people would want would vary. Maybe trace if really felt strongly.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [activemq-nms-amqp] michaelandrepearce edited a comment on issue #28: NO-JIRA: Extend logging

2019-09-13 Thread GitBox
michaelandrepearce edited a comment on issue #28: NO-JIRA: Extend logging
URL: https://github.com/apache/activemq-nms-amqp/pull/28#issuecomment-531367659
 
 
   Why would we log here? Exception here would be because exception was thrown 
within users message listener code. I would expect if it was important for a 
user to add their own logging as they see fit into their listener logic. As 
what people would want would vary


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [activemq-nms-amqp] michaelandrepearce edited a comment on issue #28: NO-JIRA: Extend logging

2019-09-12 Thread GitBox
michaelandrepearce edited a comment on issue #28: NO-JIRA: Extend logging
URL: https://github.com/apache/activemq-nms-amqp/pull/28#issuecomment-530989618
 
 
   so frame tracing should be at TRACE level, it should be expected than you 
run with this off, and you'd enable change your apps logging level to try debug 
a more complex issue. It is very verbose, and thus why its at this level. (and 
why its called frame "tracing")


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services