Re: [PR] [AMQ-9459]: Added JVM Arg to open sun.nio.ch [activemq]
jbonofre merged PR #1181: URL: https://github.com/apache/activemq/pull/1181 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [AMQ-9459]: Added JVM Arg to open sun.nio.ch [activemq]
jbonofre commented on code in PR #1181:
URL: https://github.com/apache/activemq/pull/1181#discussion_r1527932695
##
assembly/src/release/bin/activemq:
##
@@ -346,6 +346,7 @@ invokeJar(){
--add-opens java.rmi/sun.rmi.transport.tcp=ALL-UNNAMED \
--add-opens java.base/java.util.concurrent=ALL-UNNAMED \
--add-opens java.base/java.util.concurrent.atomic=ALL-UNNAMED \
+ --add-opens java.base/sun.nio.ch=ALL-UNNAMED \
Review Comment:
AFAIR, this package is not available on all JDK (not sure adoptium has it
for instance).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [AMQ-9459]: Added JVM Arg to open sun.nio.ch [activemq]
jbonofre commented on PR #1181: URL: https://github.com/apache/activemq/pull/1181#issuecomment-2013199771 Using the default `conf/activemq.xml` with JDK openjdk version "17.0.10" 2024-01-16, I don't have any problem (including with ActiveMQ 5.17.7-SNAPSHOT. So, the problem is related to the transport connector URI you are using (that's why I was not able to reproduce the issue). The problem is about `transport.soTimeout`. I'm fixing. Thanks for your patience. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [AMQ-9459]: Added JVM Arg to open sun.nio.ch [activemq]
jbonofre commented on PR #1181: URL: https://github.com/apache/activemq/pull/1181#issuecomment-2008713319 I have to check if soTimeout exists with the transport connector you are using. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [AMQ-9459]: Added JVM Arg to open sun.nio.ch [activemq]
jbonofre commented on PR #1181: URL: https://github.com/apache/activemq/pull/1181#issuecomment-2008712721 Oh you don't use the default activemq.xml ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [AMQ-9459]: Added JVM Arg to open sun.nio.ch [activemq]
AM-19 commented on PR #1181: URL: https://github.com/apache/activemq/pull/1181#issuecomment-2008707324 Can you try with following config: ` ` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [AMQ-9459]: Added JVM Arg to open sun.nio.ch [activemq]
AM-19 commented on PR #1181: URL: https://github.com/apache/activemq/pull/1181#issuecomment-2008706383 Can you try with following config: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [AMQ-9459]: Added JVM Arg to open sun.nio.ch [activemq]
jbonofre commented on PR #1181: URL: https://github.com/apache/activemq/pull/1181#issuecomment-2008697949 I will double check. But I'm surprised that it doesn't fail on Jenkins too. I'm still convinced that it's environment related (I would have see that already else). I will check with different env. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [AMQ-9459]: Added JVM Arg to open sun.nio.ch [activemq]
AM-19 commented on PR #1181: URL: https://github.com/apache/activemq/pull/1181#issuecomment-2008696457 Hello, I checked with other JVM's as well. I see the same exception. Please share your Java version, let me test with that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [AMQ-9459]: Added JVM Arg to open sun.nio.ch [activemq]
AM-19 commented on PR #1181: URL: https://github.com/apache/activemq/pull/1181#issuecomment-2003165380 > It works for me. Which JDK are you using (provider) ? > > I will do some tests but it looks like an environment issue to me. Let me double check. Hello, I tested using Java Runtime: Eclipse Adoptium 17.0.10. Just to double check, can you share your Runtime, Ill test using the exact version, Will see how it goes, -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [AMQ-9459]: Added JVM Arg to open sun.nio.ch [activemq]
jbonofre commented on PR #1181: URL: https://github.com/apache/activemq/pull/1181#issuecomment-2003071743 It works for me. Which JDK are you using (provider) ? I will do some tests but it looks like an environment issue to me. Let me double check. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [AMQ-9459]: Added JVM Arg to open sun.nio.ch [activemq]
AM-19 commented on PR #1181: URL: https://github.com/apache/activemq/pull/1181#issuecomment-2003066163 > Ok, so I don't think we need it :) Actually It does occur in 6.x  My bad I mis-spelled property while testing. ` ERROR | Could not set property soTimeout on ServerSocket[addr=/0:0:0:0:0:0:0:0,localport=61616] java.lang.reflect.InaccessibleObjectException: Unable to make public void sun.nio.ch.ServerSocketAdaptor.setSoTimeout(int) throws java.net.SocketException accessible: module java.base does not "opens sun.nio.ch" to unnamed module @6f0603b8 at java.base/java.lang.reflect.AccessibleObject.checkCanSetAccessible(AccessibleObject.java:354) ~[?:?] at java.base/java.lang.reflect.AccessibleObject.checkCanSetAccessible(AccessibleObject.java:297) ~[?:?] at java.base/java.lang.reflect.Method.checkCanSetAccessible(Method.java:199) ~[?:?] at java.base/java.lang.reflect.Method.setAccessible(Method.java:193) ~[?:?] at org.apache.activemq.util.IntrospectionSupport.setProperty(IntrospectionSupport.java:179) ~[activemq-client-6.1.0.jar:6.1.0] at org.apache.activemq.util.IntrospectionSupport.setProperties(IntrospectionSupport.java:155) ~[activemq-client-6.1.0.jar:6.1.0] at org.apache.activemq.transport.tcp.TcpTransportServer.configureServerSocket(TcpTransportServer.java:204) ~[activemq-client-6.1.0.jar:6.1.0] at org.apache.activemq.transport.tcp.TcpTransportServer.bind(TcpTransportServer.java:146) ~[activemq-client-6.1.0.jar:6.1.0] at org.apache.activemq.transport.auto.nio.AutoNioSslTransportFactory.doBind(AutoNioSslTransportFactory.java:122) ~[activemq-broker-6.1.0.jar:6.1.0] at org.apache.activemq.transport.TransportFactorySupport.bind(TransportFactorySupport.java:40) ~[activemq-broker-6.1.0.jar:6.1.0] at org.apache.activemq.broker.TransportConnector.createTransportServer(TransportConnector.java:349) ~[activemq-broker-6.1.0.jar:6.1.0] at org.apache.activemq.broker.TransportConnector.getServer(TransportConnector.java:148) ~[activemq-broker-6.1.0.jar:6.1.0] at org.apache.activemq.broker.TransportConnector.asManagedConnector(TransportConnector.java:113) ~[activemq-broker-6.1.0.jar:6.1.0] at org.apache.activemq.broker.BrokerService.registerConnectorMBean(BrokerService.java:2248) ~[activemq-broker-6.1.0.jar:6.1.0] at org.apache.activemq.broker.BrokerService.startTransportConnector(BrokerService.java:2735) ~[activemq-broker-6.1.0.jar:6.1.0] at org.apache.activemq.broker.BrokerService.startAllConnectors(BrokerService.java:2631) ~[activemq-broker-6.1.0.jar:6.1.0] at org.apache.activemq.broker.BrokerService.doStartBroker(BrokerService.java:768) ~[activemq-broker-6.1.0.jar:6.1.0] at org.apache.activemq.broker.BrokerService.startBroker(BrokerService.java:730) ~[activemq-broker-6.1.0.jar:6.1.0] at org.apache.activemq.broker.BrokerService.start(BrokerService.java:628) ~[activemq-broker-6.1.0.jar:6.1.0] at org.apache.activemq.xbean.XBeanBrokerService.afterPropertiesSet(XBeanBrokerService.java:73) ~[activemq-spring-6.1.0.jar:6.1.0] at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:?] at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77) ~[?:?] at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:?] at java.base/java.lang.reflect.Method.invoke(Method.java:568) ~[?:?] ` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [AMQ-9459]: Added JVM Arg to open sun.nio.ch [activemq]
jbonofre commented on PR #1181: URL: https://github.com/apache/activemq/pull/1181#issuecomment-2003063759 Ok, so I don't think we need it :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [AMQ-9459]: Added JVM Arg to open sun.nio.ch [activemq]
AM-19 commented on PR #1181: URL: https://github.com/apache/activemq/pull/1181#issuecomment-2003060436 Correction: Issue does not occur in 6.x -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [AMQ-9459]: Added JVM Arg to open sun.nio.ch [activemq]
AM-19 commented on PR #1181: URL: https://github.com/apache/activemq/pull/1181#issuecomment-2003050122 > @AM-19 ok it's what I thought: let me check but I don't think it happens on 6.x. Let me validate on 6.x, Will reply in this Thread. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [AMQ-9459]: Added JVM Arg to open sun.nio.ch [activemq]
jbonofre commented on PR #1181: URL: https://github.com/apache/activemq/pull/1181#issuecomment-2003048198 @AM-19 ok it's what I thought: let me check but I don't think it happens on 6.x. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [AMQ-9459]: Added JVM Arg to open sun.nio.ch [activemq]
AM-19 commented on PR #1181: URL: https://github.com/apache/activemq/pull/1181#issuecomment-2003045074 > Which versions of AMQ are you refering ? Issue is Observed in 5.17.6, but will Ideally occur in 5.18.x and 6.0.x -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [AMQ-9459]: Added JVM Arg to open sun.nio.ch [activemq]
jbonofre commented on code in PR #1181:
URL: https://github.com/apache/activemq/pull/1181#discussion_r1527932695
##
assembly/src/release/bin/activemq:
##
@@ -346,6 +346,7 @@ invokeJar(){
--add-opens java.rmi/sun.rmi.transport.tcp=ALL-UNNAMED \
--add-opens java.base/java.util.concurrent=ALL-UNNAMED \
--add-opens java.base/java.util.concurrent.atomic=ALL-UNNAMED \
+ --add-opens java.base/sun.nio.ch=ALL-UNNAMED \
Review Comment:
AFAIR, this package is not available on all JDK (not sure adoptium has it
for instance).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [AMQ-9459]: Added JVM Arg to open sun.nio.ch [activemq]
jbonofre commented on PR #1181: URL: https://github.com/apache/activemq/pull/1181#issuecomment-2003017023 Which versions of AMQ are you refering ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
