jcamachor commented on a change in pull request #1212:
URL: https://github.com/apache/hive/pull/1212#discussion_r450617751
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/CastStringToDate.java
##########
@@ -116,14 +118,16 @@ public void evaluate(VectorizedRowBatch batch) {
private void evaluate(LongColumnVector outV, BytesColumnVector inV, int i) {
String dateString = new String(inV.vector[i], inV.start[i], inV.length[i],
StandardCharsets.UTF_8);
- if (dateParser.parseDate(dateString, sqlDate)) {
+ try {
+ Date utilDate = Date.valueOf(dateString);
Review comment:
Is this vectorized expression generated for `GenericUDFDate`? It seems
that UDF still relies on DateParser in this branch:
https://github.com/apache/hive/blob/b7f3e8ef399f510c3a6780209ebc688ef0acee8f/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFDate.java#L112
Since the change may have an effect on parsing of other dates, it may be
good to have a test run. It seems we have a jenkins active for branch-2
patches: http://130.211.9.232/job/hive-precommit/job/branch-2/ . I am wondering
whether a PR against branch-2 will trigger it or whether we can trigger it
manually. Could you verify?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
