alamb commented on a change in pull request #9494:
URL: https://github.com/apache/arrow/pull/9494#discussion_r58078
##
File path: rust/datafusion-examples/Cargo.toml
##
@@ -0,0 +1,38 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+[package]
+name = "datafusion-examples"
Review comment:
FYI @andygrove -- I am not sure what you think about possibly releasing
the examples as a crate of their own. I personally think it would be necessary.
However perhaps it would be the right way to to eventually to somehow link to
the example code from the docs.rs page
https://docs.rs/datafusion/3.0.0/datafusion/
I filed this JIRA https://issues.apache.org/jira/browse/ARROW-11863 to track
that
##
File path: rust/datafusion/Cargo.toml
##
@@ -71,9 +71,6 @@ unicode-segmentation = "^1.7.1"
rand = "0.8"
criterion = "0.3"
tempfile = "3"
-prost = "0.7"
Review comment:
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
