[GitHub] [arrow] cyb70289 commented on pull request #7340: ARROW-8979: [C++] Refine bitmap unaligned word access

2020-06-06 Thread GitBox 


cyb70289 commented on pull request #7340:
URL: https://github.com/apache/arrow/pull/7340#issuecomment-640014574


   rebased



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [arrow] cyb70289 commented on pull request #7340: ARROW-8979: [C++] Refine bitmap unaligned word access

2020-06-04 Thread GitBox 


cyb70289 commented on pull request #7340:
URL: https://github.com/apache/arrow/pull/7340#issuecomment-639202880


   > Perhaps #7352 can be merged first and then this patch can be rebased. 
Sorry about the extra work. I can help with rebasing also if it helps.
   
   No problem. I will do rebasing when #7352 merged.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [arrow] cyb70289 commented on pull request #7340: ARROW-8979: [C++] Refine bitmap unaligned word access

2020-06-03 Thread GitBox 


cyb70289 commented on pull request #7340:
URL: https://github.com/apache/arrow/pull/7340#issuecomment-638063154


   Benchmark result is better than my machine. Pick some items from above table 
(one minor glitch of the benchmark output is the items are not sorted by name 
like local benchmark)
   ```
 ==  ===  ===  

 benchmark   baseline contender
change
 ==  ===  ===  

 CopyBitmapWithOffset/8192   4.177 GiB/sec5.041 GiB/sec
20.692%
 CopyBitmapWithOffsetBoth/8192   2.309 GiB/sec2.441 GiB/sec
5.729%
 BitmapEqualsWithOffset/8192 3.521 GiB/sec3.842 GiB/sec
9.108%
 BenchmarkBitmapAnd/32768/1  3.195 GiB/sec3.223 GiB/sec
0.879%
 BenchmarkBitmapAnd/131072/1 3.270 GiB/sec3.285 GiB/sec
0.452%
 BenchmarkBitmapAnd/32768/2  3.196 GiB/sec3.225 GiB/sec
0.898%
 BenchmarkBitmapAnd/131072/2 3.266 GiB/sec3.285 GiB/sec
0.573%
 ==  ===  ===  

   ```



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [arrow] cyb70289 commented on pull request #7340: ARROW-8979: [C++] Refine bitmap unaligned word access

2020-06-03 Thread GitBox 


cyb70289 commented on pull request #7340:
URL: https://github.com/apache/arrow/pull/7340#issuecomment-638054548


   Not sure of "C GLib & Ruby" ci failure, is it related to this patch?
   
https://github.com/apache/arrow/pull/7340/checks?check_run_id=733807350#step:8:2240



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [arrow] cyb70289 commented on pull request #7340: ARROW-8979: [C++] Refine bitmap unaligned word access

2020-06-03 Thread GitBox 


cyb70289 commented on pull request #7340:
URL: https://github.com/apache/arrow/pull/7340#issuecomment-638042839


   @ursabot benchmark --suite-filter=arrow-bit-util-benchmark



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org