[GitHub] [arrow] cyb70289 commented on pull request #8232: ARROW-10051: [C++][Compute] Make aggregate kernel state mutable
cyb70289 commented on pull request #8232: URL: https://github.com/apache/arrow/pull/8232#issuecomment-696485953 CI failure is about flight test. Looks not related. https://ci.appveyor.com/project/ApacheSoftwareFoundation/arrow/builds/35331179/job/i7l5oi2mxnwytd4q#L1788 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] cyb70289 commented on pull request #8232: ARROW-10051: [C++][Compute] Make aggregate kernel state mutable
cyb70289 commented on pull request #8232: URL: https://github.com/apache/arrow/pull/8232#issuecomment-695913785 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] cyb70289 commented on pull request #8232: ARROW-10051: [C++][Compute] Make aggregate kernel state mutable
cyb70289 commented on pull request #8232: URL: https://github.com/apache/arrow/pull/8232#issuecomment-695925715 CI failure is about aws sdk: https://github.com/apache/arrow/pull/8232/checks?check_run_id=1142379049#step:8:3059 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] cyb70289 commented on pull request #8232: ARROW-10051: [C++][Compute] Make aggregate kernel state mutable
cyb70289 commented on pull request #8232: URL: https://github.com/apache/arrow/pull/8232#issuecomment-695913785 **Benchmark mode kernel on Xeon Gold 5218** - clang-9 ``` benchmark baselinecontender change % 27 ModeKernelInt8/1048576/2 198.203 MiB/sec 245.465 MiB/sec 23.845 'null_percent': 50.0 26ModeKernelInt16/1048576/1 329.690 MiB/sec 351.171 MiB/sec 6.516 'null_percent': 0.01 9 ModeKernelInt16/1048576/100 323.647 MiB/sec 344.291 MiB/sec 6.379 'null_percent': 1.0 13ModeKernelInt64/1048576/1 978.100 GiB/sec1.016 TiB/sec 6.374 'null_percent': 100.0 1 ModeKernelInt64/1048576/01.671 GiB/sec1.775 GiB/sec 6.253 , 'null_percent': 0.0 28ModeKernelInt16/1048576/1 993.549 GiB/sec1.023 TiB/sec 5.407 'null_percent': 100.0 24ModeKernelInt32/1048576/0 928.620 MiB/sec 978.819 MiB/sec 5.406 'null_percent': 0.0 29ModeKernelInt8/1048576/10 253.460 MiB/sec 267.073 MiB/sec 5.371 'null_percent': 10.0 19ModeKernelInt32/1048576/2 425.023 MiB/sec 447.163 MiB/sec 5.209 'null_percent': 50.0 20ModeKernelInt16/1048576/2 189.973 MiB/sec 199.458 MiB/sec 4.993 'null_percent': 50.0 5 ModeKernelBoolean/1048576/10 26.454 MiB/sec 27.770 MiB/sec 4.973 null_percent': 10.0 0 ModeKernelInt8/1048576/0 257.221 MiB/sec 269.917 MiB/sec 4.936 'null_percent': 0.0 12 ModeKernelInt32/1048576/100 719.901 MiB/sec 747.060 MiB/sec 3.773 'null_percent': 1.0 14 ModeKernelInt8/1048576/1 693.002 GiB/sec 717.353 GiB/sec 3.514 'null_percent': 100.0 17ModeKernelInt16/1048576/0 484.109 MiB/sec 499.499 MiB/sec 3.179 'null_percent': 0.0 8ModeKernelInt8/1048576/100 246.840 MiB/sec 253.669 MiB/sec 2.767 'null_percent': 1.0 23 ModeKernelInt32/1048576/10 654.627 MiB/sec 671.400 MiB/sec 2.562 'null_percent': 10.0 16 ModeKernelBoolean/1048576/2 27.659 MiB/sec 28.330 MiB/sec 2.427 null_percent': 50.0 25ModeKernelInt32/1048576/1 736.172 MiB/sec 753.046 MiB/sec 2.292 'null_percent': 0.01 2ModeKernelInt16/1048576/10 305.731 MiB/sec 309.157 MiB/sec 1.121 'null_percent': 10.0 6 ModeKernelInt32/1048576/11.017 TiB/sec1.018 TiB/sec 0.102 'null_percent': 100.0 7 ModeKernelBoolean/1048576/1 957.936 GiB/sec 956.161 GiB/sec -0.185 'null_percent': 100.0 21ModeKernelBoolean/1048576/100 26.571 MiB/sec 26.487 MiB/sec -0.318 'null_percent': 1.0 10 ModeKernelInt8/1048576/1 250.462 MiB/sec 245.625 MiB/sec -1.931 'null_percent': 0.01 4 ModeKernelBoolean/1048576/0 28.303 MiB/sec 27.568 MiB/sec -2.597 'null_percent': 0.0 22 ModeKernelInt64/1048576/101.265 GiB/sec1.224 GiB/sec -3.270 'null_percent': 10.0 18 ModeKernelBoolean/1048576/1 26.428 MiB/sec 25.544 MiB/sec -3.344 null_percent': 0.01 15ModeKernelInt64/1048576/11.385 GiB/sec1.338 GiB/sec -3.389 'null_percent': 0.01 3 ModeKernelInt64/1048576/1001.408 GiB/sec1.333 GiB/sec -5.332 , 'null_percent': 1.0 11ModeKernelInt64/1048576/2 861.695 MiB/sec 782.062 MiB/sec -9.241 'null_percent': 50.0 ``` - gcc-7.5 ``` benchmark baselinecontender change % 5 ModeKernelInt32/1048576/2 361.224 MiB/sec 422.818 MiB/sec 17.052 'null_percent': 50.0 9 ModeKernelInt64/1048576/01.434 GiB/sec1.650 GiB/sec 15.059 'null_percent': 0.0 25ModeKernelInt32/1048576/1 620.589 MiB/sec 712.089 MiB/sec 14.744 'null_percent': 0.01 28 ModeKernelInt32/1048576/100 621.477 MiB/sec 707.153 MiB/sec 13.786 'null_percent': 1.0 14 ModeKernelInt32/1048576/10 576.223 MiB/sec 646.869 MiB/sec 12.260 'null_percent': 10.0 21 ModeKernelInt8/1048576/2 176.230 MiB/sec 197.465 MiB/sec 12.049 'null_percent': 50.0 11ModeKernelInt16/1048576/0 362.404 MiB/sec 405.761 MiB/sec 11.964 'null_percent': 0.0 22ModeKernelInt64/1048576/1 958.410 GiB/sec1.014 TiB/sec 8.374 null_percent': 100.0 1 ModeKernelInt8/1048576/1 719.935 GiB/sec 774.349 GiB/sec 7.558 null_percent': 100.0 26ModeKernelInt32/1048576/1 984.700 GiB/sec1.029 TiB/sec 7.053 null_percent': 100.0 29ModeKernelInt64/1048576/2 668.946 MiB/sec 715.600 MiB/sec 6.974 'null_percent': 50.0 15 ModeKernelInt8/1048576/0 218.479 MiB/sec 232.068 MiB/sec 6.220 'null_percent': 0.0 2ModeKernelInt64/1048576/101.113 GiB/sec1.173 GiB/sec 5.421 'null_percent': 10.0 0 ModeKernelInt64/1048576/11.285 GiB/sec1.329 GiB/sec 3.427 'n
