[GitHub] [arrow] emkornfield commented on pull request #7110: Proof of concept for Arrow text schema
emkornfield commented on pull request #7110: URL: https://github.com/apache/arrow/pull/7110#issuecomment-624994025 > Seems pretty straightforward to read for anyone who knows about Arrow's data representation to me. A bit verbose for the simpler cases, however. Maybe we would need to add a couple extra keys at the top level... Versioning for the text schema? Something that says this is an Arrow schema? Or maybe that's not necessary. I would be prefer not to add anything that the flatbuffer parser can't parse. Feature versioning is something I've been meaning to make a proposal for but I think that might be different then what you are thinking of. I'd be OK with having this as a non-official function (probably move out of IPC namespace) to clarify this is only an convenience in the C++ (and binding code base). I think @wesm had some concerns in general about exposing this. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] emkornfield commented on pull request #7110: Proof of concept for Arrow text schema
emkornfield commented on pull request #7110: URL: https://github.com/apache/arrow/pull/7110#issuecomment-625963511 > I'm not sure what you mean by non-official function, though. Could you expand on that? Sorry, I meant not something that is supported officially in the IPC format specification (i.e. other languages need to support reading the JSON). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] emkornfield commented on pull request #7110: Proof of concept for Arrow text schema
emkornfield commented on pull request #7110: URL: https://github.com/apache/arrow/pull/7110#issuecomment-633784293 @chish42 that seems like the right order. For #1 given that you discussed it on the mailing list and people have been CCed here, since no one has objected I think we can move forward. (lazy consensus). Yes, please create a JIRA for tracking purposes (and it will give one more bump to the thread of anybody monitoring JIRA has any hard disagreements/input). For #3 I would have to think about it a bit, but maybe additional methods on Schema or functions defined in type.h 4. yes, please maybe mark the header title here as WIP until you feel comfortable for a review. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
