[GitHub] [arrow] sunchao edited a comment on pull request #7176: ARROW-8796: [Rust] feat: Allow writers to use &mut Vec

2020-05-22 Thread GitBox


sunchao edited a comment on pull request #7176:
URL: https://github.com/apache/arrow/pull/7176#issuecomment-632943566


   add @sadikovi also who authored this part of code.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [arrow] sunchao edited a comment on pull request #7176: ARROW-8796: [Rust] feat: Allow writers to use &mut Vec

2020-05-22 Thread GitBox


sunchao edited a comment on pull request #7176:
URL: https://github.com/apache/arrow/pull/7176#issuecomment-632941938


   Seems this will be a breaking change as it requires writers to be used in a 
different way? and I think the new way is not as intuitive as the old one.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org