[GitHub] [arrow] wesm commented on pull request #6402: ARROW-7831: [Java] do not allocate a new offset buffer if the slice starts at 0 since the relative offset pointer would be unchanged

2020-07-09 Thread GitBox


wesm commented on pull request #6402:
URL: https://github.com/apache/arrow/pull/6402#issuecomment-656351932


   @rymurr could you take another look at this?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [arrow] wesm commented on pull request #6402: ARROW-7831: [Java] do not allocate a new offset buffer if the slice starts at 0 since the relative offset pointer would be unchanged

2020-06-11 Thread GitBox


wesm commented on pull request #6402:
URL: https://github.com/apache/arrow/pull/6402#issuecomment-643020217


   @scampi are you able to address the feedback on this? Otherwise this might 
need someone to pick it up since 4 months have passed



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [arrow] wesm commented on pull request #6402: ARROW-7831: [Java] do not allocate a new offset buffer if the slice starts at 0 since the relative offset pointer would be unchanged

2020-05-30 Thread GitBox


wesm commented on pull request #6402:
URL: https://github.com/apache/arrow/pull/6402#issuecomment-636402809


   ping @siddharthteotia or @rymurr 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org