[GitHub] [arrow] wesm commented on pull request #7126: [C++][Python] Remove boost_regex dependency

2020-06-09 Thread GitBox


wesm commented on pull request #7126:
URL: https://github.com/apache/arrow/pull/7126#issuecomment-640648593


   That's annoying. I have a feeling we may end up vendoring and applying small 
patches to Thrift eventually (it's "only" 18 KLOC). We could discuss on the 
mailing list



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [arrow] wesm commented on pull request #7126: [C++][Python] Remove boost_regex dependency

2020-06-06 Thread GitBox


wesm commented on pull request #7126:
URL: https://github.com/apache/arrow/pull/7126#issuecomment-640060481


   Alright. We could still remove the boost::regex dependency since Thrift does 
not require that, but I'll close this for now



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [arrow] wesm commented on pull request #7126: [C++][Python] Remove boost_regex dependency

2020-06-05 Thread GitBox


wesm commented on pull request #7126:
URL: https://github.com/apache/arrow/pull/7126#issuecomment-639899976


   How do you want to proceed here, should we abandon this?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org