[GitHub] [arrow] wgtmac commented on pull request #33739: GH-33655: [C++][Parquet] Fix occasional failure in TestArrowReadWrite.MultithreadedWrite
wgtmac commented on PR #33739: URL: https://github.com/apache/arrow/pull/33739#issuecomment-1398122729 @pitrou @emkornfield Could you please take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] wgtmac commented on pull request #33739: GH-33655: [C++][Parquet] Fix occasional failure in TestArrowReadWrite.MultithreadedWrite
wgtmac commented on PR #33739: URL: https://github.com/apache/arrow/pull/33739#issuecomment-1387013313 > Revision: [5d902c4](https://github.com/apache/arrow/commit/5d902c4a8ccc8381522f91a8f1a1bae41f316977) > > Submitted crossbow builds: [ursacomputing/crossbow @ actions-06834b1e91](https://github.com/ursacomputing/crossbow/branches/all?query=actions-06834b1e91) > > Task Status > test-alpine-linux-cpp [![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-06834b1e91-github-test-alpine-linux-cpp)](https://github.com/ursacomputing/crossbow/actions/runs/3947580643/jobs/6756559079) > test-build-cpp-fuzz[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-06834b1e91-github-test-build-cpp-fuzz)](https://github.com/ursacomputing/crossbow/actions/runs/3947580286/jobs/6756558416) > test-conda-cpp [![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-06834b1e91-github-test-conda-cpp)](https://github.com/ursacomputing/crossbow/actions/runs/3947581012/jobs/6756560038) > test-conda-cpp-valgrind [![Azure](https://camo.githubusercontent.com/fbf64874bfe4c1c4efe5d56d7f94899a2a7e703594b6de42531dad3083dac6a8/68747470733a2f2f6465762e617a7572652e636f6d2f75727361636f6d707574696e672f63726f7373626f772f5f617069732f6275696c642f7374617475732f75727361636f6d707574696e672e63726f7373626f773f6272616e63684e616d653d616374696f6e732d303638333462316539312d617a7572652d746573742d636f6e64612d6370702d76616c6772696e64)](https://github.com/ursacomputing/crossbow/runs/10721023586) > test-cuda-cpp [![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-06834b1e91-github-test-cuda-cpp)](https://github.com/ursacomputing/crossbow/actions/runs/3947584031/jobs/6756567432) > test-debian-10-cpp-amd64 [![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-06834b1e91-github-test-debian-10-cpp-amd64)](https://github.com/ursacomputing/crossbow/actions/runs/3947587365/jobs/6756575033) > test-debian-10-cpp-i386[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-06834b1e91-github-test-debian-10-cpp-i386)](https://github.com/ursacomputing/crossbow/actions/runs/3947586699/jobs/6756573475) > test-debian-11-cpp-amd64 [![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-06834b1e91-github-test-debian-11-cpp-amd64)](https://github.com/ursacomputing/crossbow/actions/runs/3947583668/jobs/6756566377) > test-debian-11-cpp-i386[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-06834b1e91-github-test-debian-11-cpp-i386)](https://github.com/ursacomputing/crossbow/actions/runs/3947585276/jobs/6756570450) > test-fedora-35-cpp [![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-06834b1e91-github-test-fedora-35-cpp)](https://github.com/ursacomputing/crossbow/actions/runs/3947585952/jobs/6756571823) > test-ubuntu-18.04-cpp [![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-06834b1e91-github-test-ubuntu-18.04-cpp)](https://github.com/ursacomputing/crossbow/actions/runs/3947582905/jobs/6756564571) > test-ubuntu-18.04-cpp-release [![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-06834b1e91-github-test-ubuntu-18.04-cpp-release)](https://github.com/ursacomputing/crossbow/actions/runs/3947581760/jobs/6756561934) > test-ubuntu-18.04-cpp-static [![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-06834b1e91-github-test-ubuntu-18.04-cpp-static)](https://github.com/ursacomputing/crossbow/actions/runs/3947581313/jobs/6756560811) > test-ubuntu-20.04-cpp [![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-06834b1e91-github-test-ubuntu-20.04-cpp)](https://github.com/ursacomputing/crossbow/actions/runs/3947582440/jobs/6756563563) > test-ubuntu-20.04-cpp-20 [![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-06834b1e91-github-test-ubuntu-20.04-cpp-20)](https://github.com/ursacomputing/crossbow/actions/runs/3947584208/jobs/6756567874) > test-ubuntu-20.04-cpp-bundled [![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-06834b1e91-github-test-ubuntu-20.04-cpp-bundled)](https://github.com/ursacomputing/crossbow/actions/runs/3947584945/jobs/6756569777) > test-ubuntu-20.04-cpp-thread-sanitizer [![Github
[GitHub] [arrow] wgtmac commented on pull request #33739: GH-33655: [C++][Parquet] Fix occasional failure in TestArrowReadWrite.MultithreadedWrite
wgtmac commented on PR #33739: URL: https://github.com/apache/arrow/pull/33739#issuecomment-1386752574 > Do you have error logs? I ran TSAN and found the following data race, though it didn't report the root cause. ``` Data race (pid=96483) Read of size 2 at 0x00010ed0bd78 by thread T6: at 0x103ab997c parquet::TypedColumnWriterImpl >::MaybeCalculateValidityBits(short const*, long long, long long*, long long*, long long*) ([column_writer.cc:1420](http://column_writer.cc:1420/)) at 0x103ab9458 parquet::TypedColumnWriterImpl >::WriteBatchSpaced(long long, short const*, short const*, unsigned char const*, long long, double const*)::'lambda'(long long, long long)::operator()(long long, long long) const ([column_writer.cc:1196](http://column_writer.cc:1196/)) at 0x103ab9308 void parquet::DoInBatches >::WriteBatchSpaced(long long, short const*, short const*, unsigned char const*, long long, double const*)::'lambda'(long long, long long)&>(long long, long long, parquet::TypedColumnWriterImpl >::WriteBatchSpaced(long long, short const*, short const*, unsigned char const*, long long, double const*)::'lambda'(long long, long long)&) ([column_writer.cc:1097](http://column_writer.cc:1097/)) at 0x103aa9d90 parquet::TypedColumnWriterImpl >::WriteBatchSpaced(long long, short const*, short const*, unsigned char const*, long long, double const*) ([column_writer.cc:1218](http://column_writer.cc:1218/)) at 0x10334 non-virtual thunk to parquet::TypedColumnWriterImpl >::WriteBatchSpaced(long long, short const*, short const*, unsigned char const*, long long, double const*) ([column_writer.cc](http://column_writer.cc/)) at 0x103a03a24 arrow::Status parquet::WriteArrowZeroCopy >(arrow::Array const&, long long, short const*, short const*, parquet::ArrowWriteContext*, parquet::TypedColumnWriter >*, bool) ([column_writer.cc:1798](http://column_writer.cc:1798/)) at 0x103a03590 parquet::TypedColumnWriterImpl >::WriteArrowDense(short const*, short const*, long long, arrow::Array const&, parquet::ArrowWriteContext*, bool) ([column_writer.cc:2144](http://column_writer.cc:2144/)) at 0x103aaa18c parquet::TypedColumnWriterImpl >::WriteArrow(short const*, short const*, long long, arrow::Array const&, parquet::ArrowWriteContext*, bool) ([column_writer.cc:1243](http://column_writer.cc:1243/)) at 0x103aaa804 non-virtual thunk to parquet::TypedColumnWriterImpl >::WriteArrow(short const*, short const*, long long, arrow::Array const&, parquet::ArrowWriteContext*, bool) ([column_writer.cc](http://column_writer.cc/)) at 0x1038ad2dc parquet::arrow::(anonymous namespace)::ArrowColumnWriterV2::Write(parquet::ArrowWriteContext*)::'lambda'(parquet::arrow::MultipathLevelBuilderResult const&)::operator()(parquet::arrow::MultipathLevelBuilderResult const&) const ([writer.cc:142](http://writer.cc:142/)) at 0x1038acf74 decltype(static_cast(fp)(static_cast(fp0))) std::__1::__invoke(parquet::arrow::(anonymous namespace)::ArrowColumnWriterV2::Write(parquet::ArrowWriteContext*)::'lambda'(parquet::arrow::MultipathLevelBuilderResult const&)&, parquet::arrow::MultipathLevelBuilderResult const&) (type_traits:3640) at 0x1038aceb0 arrow::Status std::__1::__invoke_void_return_wrapper::__call(parquet::arrow::(anonymous namespace)::ArrowColumnWriterV2::Write(parquet::ArrowWriteContext*)::'lambda'(parquet::arrow::MultipathLevelBuilderResult const&)&, parquet::arrow::MultipathLevelBuilderResult const&) (invoke.h:30) at 0x1038ace24 std::__1::__function::__alloc_func, arrow::Status (parquet::arrow::MultipathLevelBuilderResult const&)>::operator()(parquet::arrow::MultipathLevelBuilderResult const&) (function.h:180) at 0x1038aadcc std::__1::__function::__func, arrow::Status (parquet::arrow::MultipathLevelBuilderResult const&)>::operator()(parquet::arrow::MultipathLevelBuilderResult const&) (function.h:354) at 0x10377d050 std::__1::__function::__value_func::operator()(parquet::arrow::MultipathLevelBuilderResult const&) const (function.h:507) at 0x10377b7ac std::__1::function::operator()(parquet::arrow::MultipathLevelBuilderResult const&) const (function.h:1184) at 0x10377b444 parquet::arrow::(anonymous namespace)::WritePath(parquet::arrow::ElementRange, parquet::arrow::(anonymous namespace)::PathInfo*, parquet::ArrowWriteContext*, std::__1::function) ([path_internal.cc:637](http://path_internal.cc:637/)) at 0x10377ab0c parquet::arrow::MultipathLevelBuilderImpl::Write(int, parquet::ArrowWriteContext*, std::__1::function) ([path_internal.cc:874](http://path_internal.cc:874/)) at 0x1038a096c parquet::arrow::(anonymous namespace)::ArrowColumnWriterV2::Write(parquet::ArrowWriteContext*) ([writer.cc:142](http://writer.cc:142/)) at 0x1038af078 parquet::arrow::FileWriterImpl::WriteRecordBatch(arrow::RecordBatch const&)::'lambda'(long long, long long)::operator()(long long, long long)
[GitHub] [arrow] wgtmac commented on pull request #33739: GH-33655: [C++][Parquet] Fix occasional failure in TestArrowReadWrite.MultithreadedWrite
wgtmac commented on PR #33739: URL: https://github.com/apache/arrow/pull/33739#issuecomment-1386700978 @cyb70289 @westonpace @lidavidm Could you please take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org