[GitHub] [arrow] zhztheplayer commented on issue #6967: ARROW-8499: [C++][Dataset] In ScannerBuilder, batch_size will not wor…

2020-04-20 Thread GitBox 


zhztheplayer commented on issue #6967:
URL: https://github.com/apache/arrow/pull/6967#issuecomment-616345112


   OK but as the PR is already merged, maybe a follow-up JIRA ticket is needed?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [arrow] zhztheplayer commented on issue #6967: ARROW-8499: [C++][Dataset] In ScannerBuilder, batch_size will not wor…

2020-04-19 Thread GitBox 


zhztheplayer commented on issue #6967:
URL: https://github.com/apache/arrow/pull/6967#issuecomment-616276272


   > Unit test possible?
   
   Is unit test always required for a quick fix like this? I thought this may 
belong to the kind of changes that could be easily proved right.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org