[GitHub] [beam] TheNeuralBit commented on pull request #12145: [BEAM-10136] [BEAM-10135] Add JdbcIO for cross-language with python wrapper

2020-07-01 Thread GitBox 


TheNeuralBit commented on pull request #12145:
URL: https://github.com/apache/beam/pull/12145#issuecomment-652719638


   Run XVR_Flink PostCommit



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [beam] TheNeuralBit commented on pull request #12145: [BEAM-10136] [BEAM-10135] Add JdbcIO for cross-language with python wrapper

2020-07-01 Thread GitBox 


TheNeuralBit commented on pull request #12145:
URL: https://github.com/apache/beam/pull/12145#issuecomment-652720997


   > Unfortunately the python test is taken by tox precommit suites - I suppose 
it shouldn't?
   
   I think that's actually ok. The precommit will uses the fn api runner, which 
supports cross-language transforms. I haven't been able to run SqlTransform 
with the fn api runner yet though (BEAM-10010), which is why I still have it 
disabled in sql_test. 
   
   If JdbcIO is also having trouble running on the fn api runner you could 
disable it like I did in sql_test, as long as we're still testing continuously 
with XVR_Flink and XVR_Spark, but we should file a jira for JdbcIO on fn api 
runner and track down the cause.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [beam] TheNeuralBit commented on pull request #12145: [BEAM-10136] [BEAM-10135] Add JdbcIO for cross-language with python wrapper

2020-07-06 Thread GitBox 


TheNeuralBit commented on pull request #12145:
URL: https://github.com/apache/beam/pull/12145#issuecomment-654539018


   From jenkins it looks like the test is timing out:
   ```
   04:38:09 INFO:apache_beam.runners.portability.portable_runner:Job state 
changed to RUNNING
   05:41:59 Build timed out (after 100 minutes). Marking the build as aborted.
   ```
   
   I noticed a similar behavior when I try to run the test locally with
   ```
   python setup.py nosetests \
   --tests apache_beam.io.external.xlang_jdbcio_it_test \
   --test-pipeline-options="--runner=FlinkRunner"
   ```
   Eventually the job server logs that the pipeline is finished but then the 
test runner just hangs. I'm not sure where it's getting stuck



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [beam] TheNeuralBit commented on pull request #12145: [BEAM-10136] [BEAM-10135] Add JdbcIO for cross-language with python wrapper

2020-07-08 Thread GitBox 


TheNeuralBit commented on pull request #12145:
URL: https://github.com/apache/beam/pull/12145#issuecomment-655841690


   Interesting. Looks like it is running fine on Python PostCommit, and I'm 
able to run it locally with the fn api runner as well:
   ```
   python setup.py nosetests --tests 
apache_beam.io.external.xlang_jdbcio_it_test
   ```
   (cc: @sclukas77 - it looks like this command should work for you now if you 
have all the dependencies built)
   
   Running on Python PostCommit is fine with me, I just wanted to make sure we 
have it running continuously _somewhere_.
   
   Can you file a jira so we don't forget to investigate the issue on 
Flink/Spark?
   
   I'd like to take another look through the code when I'm fresh tomorrow, 
sorry this is taking so long :grimacing: 
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [beam] TheNeuralBit commented on pull request #12145: [BEAM-10136] [BEAM-10135] Add JdbcIO for cross-language with python wrapper

2020-07-09 Thread GitBox 


TheNeuralBit commented on pull request #12145:
URL: https://github.com/apache/beam/pull/12145#issuecomment-656289151


   > Those tests run on Flink and Spark in Python Postcommit suite.
   
   Oh really? I didn't realize that. How do you know? I'm having a hard time 
looking through the logs to verify since they're so large.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [beam] TheNeuralBit commented on pull request #12145: [BEAM-10136] [BEAM-10135] Add JdbcIO for cross-language with python wrapper

2020-07-10 Thread GitBox 


TheNeuralBit commented on pull request #12145:
URL: https://github.com/apache/beam/pull/12145#issuecomment-656790677


   Why are they taking ~15min? When I run them locally they're quite fast



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org