[GitHub] [beam] aaltay commented on a change in pull request #12166: [BEAM-10404] Cancel queued/running GitHub Action builds on second push to PR
aaltay commented on a change in pull request #12166: URL: https://github.com/apache/beam/pull/12166#discussion_r451063093 ## File path: .github/workflows/cancel.yml ## @@ -16,7 +16,7 @@ # under the License. name: Cancel -on: [push] +on: [push, pull_request] Review comment: > e.g. new merge commit on master appear. So it is possible to run rests without PR. I do not understand how/when this would happen. Because we do not allow direct pushes to master. And if it is already in master a PR would not be helpful. Maybe this example applies to release branches? Overall, I am fine with the change. It is ok to cancel tests when a new PR is created. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [beam] aaltay commented on a change in pull request #12166: [BEAM-10404] Cancel queued/running GitHub Action builds on second push to PR
aaltay commented on a change in pull request #12166: URL: https://github.com/apache/beam/pull/12166#discussion_r451063093 ## File path: .github/workflows/cancel.yml ## @@ -16,7 +16,7 @@ # under the License. name: Cancel -on: [push] +on: [push, pull_request] Review comment: > e.g. new merge commit on master appear. So it is possible to run rests without PR. I do not understand how/when this would happen. Because we do not allow direct pushes to master. And if it is already in master a PR would not be helpful. Maybe this example applies to release branches? Overall, I am fine with the change. It is ok to cancel tests when a new PR is created. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [beam] aaltay commented on a change in pull request #12166: [BEAM-10404] Cancel queued/running GitHub Action builds on second push to PR
aaltay commented on a change in pull request #12166: URL: https://github.com/apache/beam/pull/12166#discussion_r450559375 ## File path: .github/workflows/cancel.yml ## @@ -16,7 +16,7 @@ # under the License. name: Cancel -on: [push] +on: [push, pull_request] Review comment: When does a 'push' event and a 'pull_request' event happen? AFAIK, no tests are running before a PR is created. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
